Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 46163008: Revert "Re-land deferred compositing updates with fixed assumptions" (Closed)

Created:
7 years, 1 month ago by yurys
Modified:
7 years, 1 month ago
Reviewers:
caseq, shawnsingh, jamesr
CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, zoltan1, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, jchaffraix+rendering, devtools-reviews_chromium.org, bemjb+rendering_chromium.org, aandrey+blink_chromium.org, arv+blink
Visibility:
Public.

Description

Revert "Re-land deferred compositing updates with fixed assumptions" This reverts commit r161126. It caused compositing/video/video-poster.html crashes in debug mode and made inspector-protocol/layers/get-layers.html fail on Mac and Win: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=compositing%2Fvideo%2Fvideo-poster.html%2Cinspector-protocol%2Flayers%2Fget-layers.html BUG=229679, 302726, 309733 TBR=shawnsingh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -310 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/gestures/gesture-tapHighlight-on-promoted-overflow-div-scrolled.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling-after-sibling-display-change.html View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling-after-sibling-z-index-change.html View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/overflow/dynamic-composited-scrolling-status.html View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/compositing/overflow/opt-into-composited-scrolling-positioned-ancestor.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/overflow/resources/automatically-opt-into-composited-scrolling.js View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-inside-composited-intermediate-layer.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-with-composited-child.html View 1 chunk +1 line, -2 lines 0 comments Download
D LayoutTests/fast/events/touch/compositor-touch-hit-rects-trigger-commit.html View 1 chunk +0 lines, -49 lines 0 comments Download
M LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js View 1 chunk +1 line, -6 lines 0 comments Download
M LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html View 2 chunks +3 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector-protocol/layers/get-layers.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector-protocol/layers/get-layers-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 3 chunks +24 lines, -0 lines 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 3 chunks +2 lines, -13 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 5 chunks +23 lines, -51 lines 0 comments Download
M Source/core/rendering/CompositedLayerMapping.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderGeometryMap.cpp View 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerCompositor.h View 5 chunks +6 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 15 chunks +25 lines, -65 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +14 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerStackingNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 3 chunks +2 lines, -24 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/PageWidgetDelegate.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 11 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yurys
7 years, 1 month ago (2013-11-01 08:31:52 UTC) #1
yurys
7 years, 1 month ago (2013-11-01 08:32:44 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r161146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698