Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: Source/core/page/scrolling/ScrollingCoordinator.h

Issue 46163008: Revert "Re-land deferred compositing updates with fixed assumptions" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/scrolling/ScrollingCoordinator.h
diff --git a/Source/core/page/scrolling/ScrollingCoordinator.h b/Source/core/page/scrolling/ScrollingCoordinator.h
index 0c429131bbf7de6649822da248299a3bb15811e1..e5a1d1a0e729ddddd966fef6c26fd565fec42134 100644
--- a/Source/core/page/scrolling/ScrollingCoordinator.h
+++ b/Source/core/page/scrolling/ScrollingCoordinator.h
@@ -60,13 +60,8 @@ public:
// Return whether this scrolling coordinator handles scrolling for the given frame view.
bool coordinatesScrollingForFrameView(FrameView*) const;
- // Called when any frame has done its layout.
- void notifyLayoutUpdated();
-
- // Should be called after compositing has been updated.
- void updateAfterCompositingChange();
-
- bool needsToUpdateAfterCompositingChange() const { return m_scrollGestureRegionIsDirty || m_touchEventTargetRectsAreDirty; }
+ // Should be called whenever the given frame view has been laid out.
+ void frameViewLayoutUpdated(FrameView*);
// Should be called whenever a wheel event handler is added or removed in the
// frame view's underlying document.
@@ -113,8 +108,6 @@ public:
String mainThreadScrollingReasonsAsText() const;
Region computeShouldHandleScrollGestureOnMainThreadRegion(const Frame*, const IntPoint& frameLocation) const;
- void updateTouchEventTargetRectsIfNeeded();
-
protected:
explicit ScrollingCoordinator(Page*);
@@ -129,10 +122,6 @@ protected:
Page* m_page;
- // Dirty flags used to idenfity what really needs to be computed after compositing is updated.
- bool m_scrollGestureRegionIsDirty;
- bool m_touchEventTargetRectsAreDirty;
-
private:
void recomputeWheelEventHandlerCountForFrameView(FrameView*);
void setShouldUpdateScrollLayerPositionOnMainThread(MainThreadScrollingReasons);
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698