Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 461483002: Remove an unnecessary paintInvalidationForWholeRenderer from HTMLFormControlElement (Closed)

Created:
6 years, 4 months ago by pdr.
Modified:
6 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove an unnecessary paintInvalidationForWholeRenderer from HTMLFormControlElement While reviewing https://codereview.chromium.org/455223002 I noticed this paintInvalidationForWholeRenderer call which seems unnecessary. This patch removes a call to paintInvalidationForWholeRenderer when the focus of an element changes. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pdr.
6 years, 4 months ago (2014-08-10 21:54:41 UTC) #1
tkent
lgtm because no tests failed. However I don't understand why nothing is necessary. Updating m_wasFocusedByMouse ...
6 years, 4 months ago (2014-08-11 02:31:21 UTC) #2
pdr.
On 2014/08/11 02:31:21, tkent wrote: > lgtm because no tests failed. > However I don't ...
6 years, 4 months ago (2014-08-11 04:43:06 UTC) #3
tkent
On 2014/08/11 04:43:06, pdr wrote: > My understanding of the original patch is that we ...
6 years, 4 months ago (2014-08-11 06:32:52 UTC) #4
pdr.
On 2014/08/11 06:32:52, tkent wrote: > On 2014/08/11 04:43:06, pdr wrote: > > My understanding ...
6 years, 4 months ago (2014-08-11 23:11:59 UTC) #5
tkent
On 2014/08/11 23:11:59, pdr wrote: > On 2014/08/11 06:32:52, tkent wrote: > > On 2014/08/11 ...
6 years, 4 months ago (2014-08-12 01:09:03 UTC) #6
pdr.
On 2014/08/12 01:09:03, tkent wrote: > On 2014/08/11 23:11:59, pdr wrote: > > On 2014/08/11 ...
6 years, 4 months ago (2014-08-12 02:17:34 UTC) #7
tkent
We already have tests. LayoutTests/fast/forms/*/*-focus-by-mouse-then-keydown.html So, I was surprised that try bots passed.
6 years, 4 months ago (2014-08-12 02:23:25 UTC) #8
pdr.
6 years, 3 months ago (2014-08-27 04:32:11 UTC) #9
On 2014/08/12 02:23:25, tkent wrote:
> We already have tests.
>   LayoutTests/fast/forms/*/*-focus-by-mouse-then-keydown.html
> 
> So, I was surprised that try bots passed.

Closing this review in favor of https://codereview.chromium.org/504343004/ :)

Powered by Google App Engine
This is Rietveld 408576698