Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: Source/core/html/HTMLFormControlElement.cpp

Issue 461483002: Remove an unnecessary paintInvalidationForWholeRenderer from HTMLFormControlElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 return shouldShowFocusRingOnMouseFocus() || !m_wasFocusedByMouse; 344 return shouldShowFocusRingOnMouseFocus() || !m_wasFocusedByMouse;
345 } 345 }
346 346
347 void HTMLFormControlElement::willCallDefaultEventHandler(const Event& event) 347 void HTMLFormControlElement::willCallDefaultEventHandler(const Event& event)
348 { 348 {
349 if (!event.isKeyboardEvent() || event.type() != EventTypeNames::keydown) 349 if (!event.isKeyboardEvent() || event.type() != EventTypeNames::keydown)
350 return; 350 return;
351 if (!m_wasFocusedByMouse) 351 if (!m_wasFocusedByMouse)
352 return; 352 return;
353 m_wasFocusedByMouse = false; 353 m_wasFocusedByMouse = false;
354 if (renderer())
355 renderer()->paintInvalidationForWholeRenderer();
356 } 354 }
357 355
358 356
359 short HTMLFormControlElement::tabIndex() const 357 short HTMLFormControlElement::tabIndex() const
360 { 358 {
361 // Skip the supportsFocus check in HTMLElement. 359 // Skip the supportsFocus check in HTMLElement.
362 return Element::tabIndex(); 360 return Element::tabIndex();
363 } 361 }
364 362
365 bool HTMLFormControlElement::recalcWillValidate() const 363 bool HTMLFormControlElement::recalcWillValidate() const
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
532 530
533 void HTMLFormControlElement::setFocus(bool flag) 531 void HTMLFormControlElement::setFocus(bool flag)
534 { 532 {
535 LabelableElement::setFocus(flag); 533 LabelableElement::setFocus(flag);
536 534
537 if (!flag && wasChangedSinceLastFormControlChangeEvent()) 535 if (!flag && wasChangedSinceLastFormControlChangeEvent())
538 dispatchFormControlChangeEvent(); 536 dispatchFormControlChangeEvent();
539 } 537 }
540 538
541 } // namespace Webcore 539 } // namespace Webcore
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698