Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 461323003: DevTools: Make Timeline tests use only model records (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
alph, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Make Timeline tests use only model records All places where raw TimelineAgent.Record was used are fixed. BUG=403684, 398785 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -114 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 7 chunks +23 lines, -55 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-bound-function.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-decode-resize.html View 1 chunk +5 lines, -4 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-frames.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-gc-event.html View 1 chunk +6 lines, -9 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-gc-event-expected.txt View 1 chunk +1 line, -8 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-layer-tree-snapshot.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-layout-reason.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-network-received-data.html View 1 chunk +3 lines, -4 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-node-reference.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-paint.html View 2 chunks +7 lines, -15 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-script-tag-1.html View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
6 years, 4 months ago (2014-08-14 12:41:47 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-14 12:44:31 UTC) #2
pfeldman
Before landing this, please make sure that the first line of issue description is equal ...
6 years, 4 months ago (2014-08-14 12:44:39 UTC) #3
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-14 12:51:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/461323003/1
6 years, 4 months ago (2014-08-14 12:52:07 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 15:27:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 180270

Powered by Google App Engine
This is Rietveld 408576698