Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: LayoutTests/inspector/timeline/timeline-gc-event.html

Issue 461323003: DevTools: Make Timeline tests use only model records (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector/timeline/timeline-gc-event.html
diff --git a/LayoutTests/inspector/timeline/timeline-gc-event.html b/LayoutTests/inspector/timeline/timeline-gc-event.html
index 3936a676f0c27e03cd7761adededd474d4a178d1..516c48945cdd403915d76153b2d86e3b33979798 100644
--- a/LayoutTests/inspector/timeline/timeline-gc-event.html
+++ b/LayoutTests/inspector/timeline/timeline-gc-event.html
@@ -16,16 +16,13 @@ function test()
{
InspectorTest.invokeAsyncWithTimeline("produceGarbageForGCEvents", validate);
- function validate(records)
+ function validate()
{
- var gcRecords = InspectorTest.filterTimelineRecords(WebInspector.TimelineModel.RecordType.GCEvent, true);
- if (gcRecords.length) {
- InspectorTest.addResult("The expected GC event record");
- InspectorTest.addObject(gcRecords[0], InspectorTest.timelinePropertyFormatters);
- } else {
- InspectorTest.addResult("FAILED: GC event record wasn't found");
- }
-
+ var gcRecord = InspectorTest.findFirstTimelineRecord(WebInspector.TimelineModel.RecordType.GCEvent);
+ if (gcRecord)
+ InspectorTest.addResult("SUCCESS: Found expected GC event record");
+ else
+ InspectorTest.addResult("FAIL: GC event record wasn't found");
InspectorTest.completeTest();
}
}
« no previous file with comments | « LayoutTests/inspector/timeline/timeline-frames.html ('k') | LayoutTests/inspector/timeline/timeline-gc-event-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698