Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 461213003: Revert of GN: Specify grit generated output paths to be the same as gyp's. (Closed)

Created:
6 years, 4 months ago by Timothy Loh
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Revert of GN: Specify grit generated output paths to be the same as gyp's. (patchset #1 of https://codereview.chromium.org/454253004/) Reason for revert: Broke GN compile and try jobs http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN Original issue's description: > GN: Specify grit generated output paths to be the same as gyp's. > > BUG=401588 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289149 TBR=brettw@chromium.org,jamescook@chromium.org,yoz@chromium.org,thestig@chromium.org NOTREECHECKS=true NOTRY=true BUG=401588 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M chrome/app/BUILD.gn View 4 chunks +2 lines, -5 lines 0 comments Download
M chrome/app/resources/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Timothy Loh
Created Revert of GN: Specify grit generated output paths to be the same as gyp's.
6 years, 4 months ago (2014-08-13 07:20:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/461213003/1
6 years, 4 months ago (2014-08-13 07:22:19 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 07:24:45 UTC) #3
Message was sent while issue was closed.
Change committed as 289209

Powered by Google App Engine
This is Rietveld 408576698