Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/app/BUILD.gn

Issue 461213003: Revert of GN: Specify grit generated output paths to be the same as gyp's. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/app/resources/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//tools/grit/grit_rule.gni") 5 import("//tools/grit/grit_rule.gni")
6 6
7 # GYP version: chrome/chrome_resources.gyp:chrome_strings 7 # GYP version: chrome/chrome_resources.gyp:chrome_strings
8 # (generate_generated_resources action) 8 # (generate_generated_resources action)
9 grit("generated_resources") { 9 grit("generated_resources") {
10 source = "generated_resources.grd" 10 source = "generated_resources.grd"
11 output_dir = "$root_gen_dir/chrome"
12 outputs = [ 11 outputs = [
13 "grit/generated_resources.h", 12 "grit/generated_resources.h",
14 "generated_resources_am.pak", 13 "generated_resources_am.pak",
15 "generated_resources_ar.pak", 14 "generated_resources_ar.pak",
16 "generated_resources_bg.pak", 15 "generated_resources_bg.pak",
17 "generated_resources_bn.pak", 16 "generated_resources_bn.pak",
18 "generated_resources_ca.pak", 17 "generated_resources_ca.pak",
19 "generated_resources_cs.pak", 18 "generated_resources_cs.pak",
20 "generated_resources_da.pak", 19 "generated_resources_da.pak",
21 "generated_resources_de.pak", 20 "generated_resources_de.pak",
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 ] 67 ]
69 } 68 }
70 69
71 # GYP version: chrome/chrome_resources.gyp:chrome_strings_map 70 # GYP version: chrome/chrome_resources.gyp:chrome_strings_map
72 action("make_generated_resources_map") { 71 action("make_generated_resources_map") {
73 # Targets should depend on generated_resources_map instead. 72 # Targets should depend on generated_resources_map instead.
74 visibility = ":generated_resources_map" 73 visibility = ":generated_resources_map"
75 74
76 script = "//chrome/browser/metrics/variations/generate_resources_map.py" 75 script = "//chrome/browser/metrics/variations/generate_resources_map.py"
77 76
78 inputs = [ "$root_gen_dir/chrome/grit/generated_resources.h" ] 77 inputs = [ "$target_gen_dir/grit/generated_resources.h" ]
79 outputs = [ "$root_gen_dir/chrome/generated_resources_map.cc" ] 78 outputs = [ "$target_gen_dir/generated_resources_map.cc" ]
80 79
81 args = rebase_path(inputs, root_build_dir) + 80 args = rebase_path(inputs, root_build_dir) +
82 rebase_path(outputs, root_build_dir) 81 rebase_path(outputs, root_build_dir)
83 82
84 deps = [ ":generated_resources" ] 83 deps = [ ":generated_resources" ]
85 } 84 }
86 85
87 # Collect the generated .cc file from make_generated_resources_map and put it 86 # Collect the generated .cc file from make_generated_resources_map and put it
88 # in a source set so targets that depend on it will link the source rather than 87 # in a source set so targets that depend on it will link the source rather than
89 # specifying it manually. This doesn't happen in the GYP build. 88 # specifying it manually. This doesn't happen in the GYP build.
90 source_set("generated_resources_map") { 89 source_set("generated_resources_map") {
91 sources = get_target_outputs(":make_generated_resources_map") 90 sources = get_target_outputs(":make_generated_resources_map")
92 } 91 }
93 92
94 # GYP version: chrome/chrome_resources.gyp:chrome_strings 93 # GYP version: chrome/chrome_resources.gyp:chrome_strings
95 # (generate_google_chrome_strings action) 94 # (generate_google_chrome_strings action)
96 grit("google_chrome_strings") { 95 grit("google_chrome_strings") {
97 source = "google_chrome_strings.grd" 96 source = "google_chrome_strings.grd"
98 output_dir = "$root_gen_dir/chrome"
99 outputs = [ 97 outputs = [
100 "grit/google_chrome_strings.h", 98 "grit/google_chrome_strings.h",
101 "google_chrome_strings_am.pak", 99 "google_chrome_strings_am.pak",
102 "google_chrome_strings_ar.pak", 100 "google_chrome_strings_ar.pak",
103 "google_chrome_strings_bg.pak", 101 "google_chrome_strings_bg.pak",
104 "google_chrome_strings_bn.pak", 102 "google_chrome_strings_bn.pak",
105 "google_chrome_strings_ca.pak", 103 "google_chrome_strings_ca.pak",
106 "google_chrome_strings_cs.pak", 104 "google_chrome_strings_cs.pak",
107 "google_chrome_strings_da.pak", 105 "google_chrome_strings_da.pak",
108 "google_chrome_strings_de.pak", 106 "google_chrome_strings_de.pak",
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 "google_chrome_strings_zh-CN.pak", 150 "google_chrome_strings_zh-CN.pak",
153 "google_chrome_strings_zh-TW.pak", 151 "google_chrome_strings_zh-TW.pak",
154 "google_chrome_strings_fake-bidi.pak", 152 "google_chrome_strings_fake-bidi.pak",
155 ] 153 ]
156 } 154 }
157 155
158 # GYP version: chrome/chrome_resources.gyp:chrome_strings 156 # GYP version: chrome/chrome_resources.gyp:chrome_strings
159 # (generate_chromium_strings action) 157 # (generate_chromium_strings action)
160 grit("chromium_strings") { 158 grit("chromium_strings") {
161 source = "chromium_strings.grd" 159 source = "chromium_strings.grd"
162 output_dir = "$root_gen_dir/chrome"
163 outputs = [ 160 outputs = [
164 "grit/chromium_strings.h", 161 "grit/chromium_strings.h",
165 "chromium_strings_am.pak", 162 "chromium_strings_am.pak",
166 "chromium_strings_ar.pak", 163 "chromium_strings_ar.pak",
167 "chromium_strings_bg.pak", 164 "chromium_strings_bg.pak",
168 "chromium_strings_bn.pak", 165 "chromium_strings_bn.pak",
169 "chromium_strings_ca.pak", 166 "chromium_strings_ca.pak",
170 "chromium_strings_cs.pak", 167 "chromium_strings_cs.pak",
171 "chromium_strings_da.pak", 168 "chromium_strings_da.pak",
172 "chromium_strings_de.pak", 169 "chromium_strings_de.pak",
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 "chromium_strings_ta.pak", 208 "chromium_strings_ta.pak",
212 "chromium_strings_te.pak", 209 "chromium_strings_te.pak",
213 "chromium_strings_th.pak", 210 "chromium_strings_th.pak",
214 "chromium_strings_tr.pak", 211 "chromium_strings_tr.pak",
215 "chromium_strings_uk.pak", 212 "chromium_strings_uk.pak",
216 "chromium_strings_vi.pak", 213 "chromium_strings_vi.pak",
217 "chromium_strings_zh-CN.pak", 214 "chromium_strings_zh-CN.pak",
218 "chromium_strings_zh-TW.pak", 215 "chromium_strings_zh-TW.pak",
219 ] 216 ]
220 } 217 }
OLDNEW
« no previous file with comments | « no previous file | chrome/app/resources/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698