Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 461153002: Fix GN action target writing with no sources list. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Fix GN action target writing with no sources list. Properly write outputs of actions that have no sources list. Previously this would lead to empty output lists in a build rule because the writer code was trying to apply the sources list to the output substitutions list. However, for actions, the output is the literal file list and should have no substitutions. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -9 lines) Patch
M tools/gn/function_get_target_outputs.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M tools/gn/ninja_action_target_writer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/gn/ninja_action_target_writer_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M tools/gn/substitution_writer.h View 1 chunk +13 lines, -0 lines 0 comments Download
M tools/gn/substitution_writer.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 4 months ago (2014-08-12 20:49:11 UTC) #1
jamesr
lgtm
6 years, 4 months ago (2014-08-12 20:53:04 UTC) #2
brettw
6 years, 4 months ago (2014-08-12 23:10:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 289109 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698