Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: tools/gn/function_get_target_outputs.cc

Issue 461153002: Fix GN action target writing with no sources list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/ninja_action_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_get_target_outputs.cc
diff --git a/tools/gn/function_get_target_outputs.cc b/tools/gn/function_get_target_outputs.cc
index d711428d2e5d2c35a99502f1a5ffe405b6f83e65..c8fedb9bcd0374f0dc1b21d831311440eaf1393b 100644
--- a/tools/gn/function_get_target_outputs.cc
+++ b/tools/gn/function_get_target_outputs.cc
@@ -20,13 +20,11 @@ void GetOutputsForTarget(const Settings* settings,
std::vector<SourceFile>* ret) {
switch (target->output_type()) {
case Target::ACTION: {
- // Actions just use the output list with no substitution. To keep things
- // simple, pass an empty "source file" in to use the same code path for
- // computing substitution outputs.
+ // Actions just use the output list with no substitution.
std::vector<SourceFile> sources;
sources.push_back(SourceFile());
- SubstitutionWriter::ApplyListToSources(
- settings, target->action_values().outputs(), sources, ret);
+ SubstitutionWriter::GetListAsSourceFiles(
+ settings, target->action_values().outputs(), ret);
break;
}
« no previous file with comments | « no previous file | tools/gn/ninja_action_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698