Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 461093002: Revert of [Mac, Win] Only show the user manager tutorial if "See what's new" is clicked. (Closed)

Created:
6 years, 4 months ago by noms (inactive)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac, Win] Only show the user manager tutorial if "See what's new" is clicked. (https://codereview.chromium.org/454153002/) Reason for revert: Breaks ProfileChooserControllerTest.InitialLayoutWithFastUserSwitcher,ProfileChooserControllerTest.InitialLayoutWithNewMenu,ProfileChooserControllerTest.OtherProfilesSortedAlphabetically on the waterfall. Original issue's description: > [Mac, Win] Only show the user manager tutorial if "See what's new" is clicked. > > - remove the profile preference that used to keep track of showing the > tutorial any time the user manager was shown for a particular profile. > > - show the upgrade bubble for local profiles as well (so that local profiles > have a chance to see the tutorial) > > - for the local profiles upgrade bubble, don't show the "Not you?" link as > it doesn't really make sense. > > BUG=399679 > TBR=rpetterson@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288817 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289005 TBR=guohui@chromium.org,rlp@chromium.org,sky@chromium.org,asvitkine@chromium.org NOTREECHECKS=true NOTRY=true BUG=399679 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -53 lines) Patch
M chrome/browser/profiles/profile.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 1 chunk +13 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 8 chunks +29 lines, -22 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 6 chunks +15 lines, -21 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
noms (inactive)
Created Revert of [Mac, Win] Only show the user manager tutorial if "See what's new" ...
6 years, 4 months ago (2014-08-12 17:42:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/461093002/1
6 years, 4 months ago (2014-08-12 17:45:37 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 17:48:13 UTC) #3
Message was sent while issue was closed.
Change committed as 289017

Powered by Google App Engine
This is Rietveld 408576698