chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm - Issue 461093002: Revert of [Mac, Win] Only show the user manager tutorial if "See what's new" is clicked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

Issue 461093002: Revert of [Mac, Win] Only show the user manager tutorial if "See what's new" is clicked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('k') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

index d2af8c784a6aa651d22cbf1c6422c4e5d0fe8d70..a568bb5e7f66368dbf94a91667958a8da8945ba5 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

@@ -101,9 +101,8 @@

subviews = [[subviews objectAtIndex:0] subviews];

// Three profiles means we should have one active card, one separator and

- // one option buttons view. We also have an update promo for the new avatar

- // menu.

- ASSERT_EQ(4U, [subviews count]);

+ // one option buttons view.

+ ASSERT_EQ(3U, [subviews count]);

// There should be two buttons and a separator in the option buttons view.

NSArray* buttonSubviews = [[subviews objectAtIndex:0] subviews];

@@ -166,9 +165,8 @@

// Three profiles means we should have one active card and a

// fast user switcher which has two "other" profiles and 2 separators, and

- // an option buttons view with its separator. We also have a promo for

- // the new avatar menu.

- ASSERT_EQ(8U, [subviews count]);

+ // an option buttons view with its separator.

+ ASSERT_EQ(7U, [subviews count]);

// There should be two buttons and a separator in the option buttons view.

// These buttons are tested in InitialLayoutWithNewMenu.

@@ -239,9 +237,8 @@

@"Test 1",

@"Test 2" };

// There are four "other" profiles, each with a button and a separator, an

- // active profile card, and an option buttons view with a separator. We

- // also have an update promo for the new avatar menu.

- ASSERT_EQ(12U, [subviews count]);

+ // active profile card, and an option buttons view with a separator.

+ ASSERT_EQ(11U, [subviews count]);

// There should be four "other profiles" items, sorted alphabetically. The

// "other profiles" start at index 2 (after the option buttons view and its

// separator), and each have a separator. We need to iterate through the