Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 460943002: ServiceWorker: Resubmit worker script MIME type fix. (Closed)

Created:
6 years, 4 months ago by xiang
Modified:
6 years, 4 months ago
Reviewers:
falken, michaeln, Lei Zhang
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Resubmit worker script MIME type fix. This is a re-submission of https://codereview.chromium.org/446323002/. Fixed the new browsertest which intercept worker script request but returns response without corret worker content type. BUG=400604 TEST=https://codereview.chromium.org/448063002/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289238

Patch Set 1 #

Messages

Total messages: 11 (0 generated)
xiang
PTAL, thanks!
6 years, 4 months ago (2014-08-12 08:50:09 UTC) #1
falken
On 2014/08/12 08:50:09, xiang wrote: > PTAL, thanks! Since the only change from the last ...
6 years, 4 months ago (2014-08-12 09:16:16 UTC) #2
Lei Zhang
chrome/ still lgtm
6 years, 4 months ago (2014-08-12 19:08:08 UTC) #3
michaeln
still lgtm2
6 years, 4 months ago (2014-08-12 19:09:11 UTC) #4
xiang
The CQ bit was checked by xiang.long@intel.com
6 years, 4 months ago (2014-08-13 00:34:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiang.long@intel.com/460943002/1
6 years, 4 months ago (2014-08-13 00:46:53 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-13 04:16:51 UTC) #7
xiang
The CQ bit was unchecked by xiang.long@intel.com
6 years, 4 months ago (2014-08-13 06:48:05 UTC) #8
xiang
The CQ bit was checked by xiang.long@intel.com
6 years, 4 months ago (2014-08-13 06:48:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiang.long@intel.com/460943002/1
6 years, 4 months ago (2014-08-13 06:48:34 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 09:49:44 UTC) #11
Message was sent while issue was closed.
Change committed as 289238

Powered by Google App Engine
This is Rietveld 408576698