content/browser/service_worker/service_worker_write_to_cache_job.cc - Issue 460943002: ServiceWorker: Resubmit worker script MIME type fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job.cc

Issue 460943002: ServiceWorker: Resubmit worker script MIME type fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/test/data/service_worker/fetch_event.js.mock-http-headers » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_write_to_cache_job.cc

diff --git a/content/browser/service_worker/service_worker_write_to_cache_job.cc b/content/browser/service_worker/service_worker_write_to_cache_job.cc

index b3e6cadfcb424aea3600d289059509ac2562d4fd..bd60ba0236dade532ea847d61de7f09171973470 100644

--- a/content/browser/service_worker/service_worker_write_to_cache_job.cc

+++ b/content/browser/service_worker/service_worker_write_to_cache_job.cc

@@ -301,6 +301,18 @@ void ServiceWorkerWriteToCacheJob::OnResponseStarted(

// response to our consumer, just don't cache it?

return;

}

+ // To prevent most user-uploaded content from being used as a serviceworker.

+ if (version_->script_url() == url_) {

+ std::string mime_type;

+ request->GetMimeType(&mime_type);

+ if (mime_type != "application/x-javascript" &&

+ mime_type != "text/javascript" &&

+ mime_type != "application/javascript") {

+ AsyncNotifyDoneHelper(net::URLRequestStatus(

+ net::URLRequestStatus::FAILED, net::ERR_FAILED));

+ return;

+ }

WriteHeadersToCache();

}