Split Shell::ToggleAppList() into ShowAppList and DismissAppList.

ash/shell.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SHELL_H_
 #define ASH_SHELL_H_
 
 #include <utility>
 #include <vector>
 
@@ skipping 213 matching lines @@
 
   void set_target_root_window(aura::Window* target_root_window) {
     target_root_window_ = target_root_window;
   }
 
   // Shows the context menu for the background and launcher at
   // |location_in_screen| (in screen coordinates).
   void ShowContextMenu(const gfx::Point& location_in_screen,
                        ui::MenuSourceType source_type);
 
-  // Toggles the app list. |window| specifies in which display the app
+  // Shows the app list. |window| specifies in which display the app
   // list should be shown. If this is NULL, the active root window
   // will be used.
+  void ShowAppList(aura::Window* anchor);

[James Cook, 2014/08/14 20:49:36]

Another option would be to provide "SetAppListVisible(bool visible,
aura::Window* anchor, Reason reason)" instead of these three methods.

The Shell API surface is already huge and that would keep things a bit smaller.

[Matt Giuca, 2014/08/15 01:00:21]

I have a slight preference to keep things the way they are (I think the current
3 methods provide a nice simple interface for a few dozen call sites; having
just 1 method makes all the call sites slightly more complex).

But I wouldn't mind if you change this.

+
+  // Dismisses the app list.
+  void DismissAppList();
+
+  // Shows the app list if it's not visible. Dismisses it otherwise.
   void ToggleAppList(aura::Window* anchor);
 
   // Returns app list target visibility.
   bool GetAppListTargetVisibility() const;
 
   // Returns app list window or NULL if it is not visible.
   aura::Window* GetAppListWindow();
 
   // Returns app list view or NULL if it is not visible.
   app_list::AppListView* GetAppListView();
@@ skipping 504 matching lines @@
 
   // Injected content::GPUDataManager support.
   scoped_ptr<GPUSupport> gpu_support_;
 
   DISALLOW_COPY_AND_ASSIGN(Shell);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SHELL_H_