Source/core/rendering/RenderLayerScrollableArea.cpp - Issue 460883002: Non-composited scrolling div should invalidate when it has descendant paints to its backing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayerScrollableArea.cpp

Issue 460883002: Non-composited scrolling div should invalidate when it has descendant paints to its backing (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Or we can do our best to live in the imperfect world... Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderLayerScrollableArea.cpp

diff --git a/Source/core/rendering/RenderLayerScrollableArea.cpp b/Source/core/rendering/RenderLayerScrollableArea.cpp

index 3dff7e2a65a3a08ab1fbf0dfea49c282ff44e81e..68b684be28fcb64268a2dff753c1c601858b3f7c 100644

--- a/Source/core/rendering/RenderLayerScrollableArea.cpp

+++ b/Source/core/rendering/RenderLayerScrollableArea.cpp

@@ -388,7 +388,8 @@ void RenderLayerScrollableArea::setScrollOffset(const IntPoint& newScrollOffset)

bool onlyScrolledCompositedLayers = scrollsOverflow()

&& !layer()->hasVisibleNonLayerContent()

&& !layer()->hasNonCompositedChild()

- && !layer()->hasBlockSelectionGapBounds();

+ && !layer()->hasBlockSelectionGapBounds()

+ && box().style()->backgroundLayers().attachment() != LocalBackgroundAttachment;

abarth-chromium 2014/08/13 00:57:21 Do we have a test that covers this case?

if (usesCompositedScrolling() || onlyScrolledCompositedLayers)

requiresRepaint = false;

« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | no next file » | no next file with comments »