Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Side by Side Diff: Source/core/rendering/RenderLayerScrollableArea.cpp

Issue 460883002: Non-composited scrolling div should invalidate when it has descendant paints to its backing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Or we can do our best to live in the imperfect world... Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 370 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent); 381 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent);
382 382
383 bool requiresRepaint = true; 383 bool requiresRepaint = true;
384 384
385 if (!box().isMarquee() && box().view()->compositor()->inCompositingMode()) { 385 if (!box().isMarquee() && box().view()->compositor()->inCompositingMode()) {
386 // Hits in virtual/gpu/fast/canvas/canvas-scroll-path-into-view.html. 386 // Hits in virtual/gpu/fast/canvas/canvas-scroll-path-into-view.html.
387 DisableCompositingQueryAsserts disabler; 387 DisableCompositingQueryAsserts disabler;
388 bool onlyScrolledCompositedLayers = scrollsOverflow() 388 bool onlyScrolledCompositedLayers = scrollsOverflow()
389 && !layer()->hasVisibleNonLayerContent() 389 && !layer()->hasVisibleNonLayerContent()
390 && !layer()->hasNonCompositedChild() 390 && !layer()->hasNonCompositedChild()
391 && !layer()->hasBlockSelectionGapBounds(); 391 && !layer()->hasBlockSelectionGapBounds()
392 && box().style()->backgroundLayers().attachment() != LocalBackground Attachment;
abarth-chromium 2014/08/13 00:57:21 Do we have a test that covers this case?
392 393
393 if (usesCompositedScrolling() || onlyScrolledCompositedLayers) 394 if (usesCompositedScrolling() || onlyScrolledCompositedLayers)
394 requiresRepaint = false; 395 requiresRepaint = false;
395 } 396 }
396 397
397 // Just schedule a full repaint of our object. 398 // Just schedule a full repaint of our object.
398 if (requiresRepaint) { 399 if (requiresRepaint) {
399 if (box().frameView()->isInPerformLayout()) 400 if (box().frameView()->isInPerformLayout())
400 box().setShouldDoFullPaintInvalidation(true); 401 box().setShouldDoFullPaintInvalidation(true);
401 else 402 else
(...skipping 1049 matching lines...) Expand 10 before | Expand all | Expand 10 after
1451 void RenderLayerScrollableArea::setTopmostScrollChild(RenderLayer* scrollChild) 1452 void RenderLayerScrollableArea::setTopmostScrollChild(RenderLayer* scrollChild)
1452 { 1453 {
1453 // We only want to track the topmost scroll child for scrollable areas with 1454 // We only want to track the topmost scroll child for scrollable areas with
1454 // overlay scrollbars. 1455 // overlay scrollbars.
1455 if (!hasOverlayScrollbars()) 1456 if (!hasOverlayScrollbars())
1456 return; 1457 return;
1457 m_nextTopmostScrollChild = scrollChild; 1458 m_nextTopmostScrollChild = scrollChild;
1458 } 1459 }
1459 1460
1460 } // namespace blink 1461 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698