Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 460743003: [DevTools] Changed checks in InspectorConsoleWindow::autogenerateMetadata (Closed)

Created:
6 years, 4 months ago by kozyatinskiy1
Modified:
6 years, 4 months ago
Reviewers:
vsevik, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@remove-script-state-from-stack-factory
Project:
blink
Visibility:
Public.

Description

[DevTools] Changed checks in InspectorConsoleWindow::autogenerateMetadata Removed part of the check related to the type of agent. This test was important when the engine used another JS engine. ScriptState no longer participates in check. And now only used to obtain the ID of context. The method createScriptCallStackForConsole now uses a method call createScriptCallStack forming a stack which is able to receive an empty stack and not adds a fake frame. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180081

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -31 lines) Patch
M Source/bindings/core/v8/ScriptCallStackFactory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptCallStackFactory.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorConsoleMessage.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorConsoleMessage.cpp View 1 2 3 5 chunks +11 lines, -20 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
kozyatinskiy1
@vsevik and @yurys, please take a look.
6 years, 4 months ago (2014-08-12 08:32:36 UTC) #1
yurys
lgtm
6 years, 4 months ago (2014-08-12 08:36:16 UTC) #2
vsevik
lgtm
6 years, 4 months ago (2014-08-12 13:22:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/460743003/120001
6 years, 4 months ago (2014-08-12 13:22:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 14:31:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 15:05:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22291)
6 years, 4 months ago (2014-08-12 15:05:49 UTC) #7
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-12 15:09:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/460743003/120001
6 years, 4 months ago (2014-08-12 15:09:54 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 15:36:48 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 16:05:29 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22301)
6 years, 4 months ago (2014-08-12 16:05:30 UTC) #12
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-12 16:19:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/460743003/120001
6 years, 4 months ago (2014-08-12 16:20:39 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 16:30:30 UTC) #15
Message was sent while issue was closed.
Change committed as 180081

Powered by Google App Engine
This is Rietveld 408576698