Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: Source/bindings/core/v8/ScriptCallStackFactory.cpp

Issue 460743003: [DevTools] Changed checks in InspectorConsoleWindow::autogenerateMetadata (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-script-state-from-stack-factory
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptCallStackFactory.h ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptCallStackFactory.cpp
diff --git a/Source/bindings/core/v8/ScriptCallStackFactory.cpp b/Source/bindings/core/v8/ScriptCallStackFactory.cpp
index 0beead8512bf2f76654dd34cd2d680adc1b9eb44..eb51c8d04262a85b919371909dde5e361056816f 100644
--- a/Source/bindings/core/v8/ScriptCallStackFactory.cpp
+++ b/Source/bindings/core/v8/ScriptCallStackFactory.cpp
@@ -111,7 +111,7 @@ PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStack(size_t maxStackSiz
return createScriptCallStack(stackTrace, maxStackSize, emptyStackIsAllowed, isolate);
}
-PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStackForConsole(size_t maxStackSize)
+PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStackForConsole(size_t maxStackSize, bool emptyStackIsAllowed)
{
size_t stackSize = 1;
if (InspectorInstrumentation::hasFrontends()) {
@@ -121,7 +121,7 @@ PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStackForConsole(size_t m
if (InspectorInstrumentation::consoleAgentEnabled(currentExecutionContext(isolate)))
stackSize = maxStackSize;
}
- return createScriptCallStack(stackSize);
+ return createScriptCallStack(stackSize, emptyStackIsAllowed);
}
PassRefPtrWillBeRawPtr<ScriptArguments> createScriptArguments(ScriptState* scriptState, const v8::FunctionCallbackInfo<v8::Value>& v8arguments, unsigned skipArgumentCount)
« no previous file with comments | « Source/bindings/core/v8/ScriptCallStackFactory.h ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698