Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 460743002: mojo: Reland "Convert gles2 to the new thunking system." (Closed)

Created:
6 years, 4 months ago by Elliot Glaysher
Modified:
6 years, 4 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

mojo: Reland "Convert gles2 to the new thunking system." This maintains the fixes for the mac isolate files, and switches around the targets used in the gyp files to fix the unit tests in component builds. BUG=386799 First Review URL: https://codereview.chromium.org/413303002 Second Review URL: https://codereview.chromium.org/448873002 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289006

Patch Set 1 #

Patch Set 2 : Use the mojo_gles2_for_loadable_module variable in more places. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+471 lines, -397 lines) Patch
M mojo/gles2/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
A mojo/gles2/gles2_impl.cc View 1 chunk +82 lines, -0 lines 0 comments Download
D mojo/gles2/gles2_support_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/gles2/gles2_support_impl.cc View 1 chunk +0 lines, -106 lines 0 comments Download
M mojo/mojo.gyp View 1 5 chunks +3 lines, -33 lines 0 comments Download
M mojo/mojo_apps.gypi View 1 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/mojo_apps_js_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_base.gyp View 2 chunks +62 lines, -1 line 0 comments Download
M mojo/mojo_examples.gypi View 1 9 chunks +8 lines, -8 lines 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +40 lines, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 5 chunks +5 lines, -64 lines 0 comments Download
M mojo/mojo_variables.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/c/gles2/gles2_export.h View 2 chunks +7 lines, -0 lines 0 comments Download
M mojo/public/gles2/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
D mojo/public/gles2/gles2_private.h View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/public/gles2/gles2_private.cc View 1 chunk +0 lines, -80 lines 0 comments Download
A mojo/public/platform/native/gles2_thunks.h View 1 chunk +106 lines, -0 lines 0 comments Download
A mojo/public/platform/native/gles2_thunks.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_thunks.cc View 2 chunks +2 lines, -8 lines 0 comments Download
A mojo/public/platform/native/thunk_export.h View 1 chunk +18 lines, -0 lines 0 comments Download
M mojo/shell/context.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/shell/in_process_dynamic_service_runner.cc View 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Elliot Glaysher
I've locally tested the tests that failed in: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/48234 And made sure that they work ...
6 years, 4 months ago (2014-08-11 20:31:18 UTC) #1
viettrungluu
Rubberstamp lgtm
6 years, 4 months ago (2014-08-11 20:34:26 UTC) #2
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 4 months ago (2014-08-11 21:15:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/460743002/20001
6 years, 4 months ago (2014-08-11 21:18:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-11 22:43:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 23:08:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/4545)
6 years, 4 months ago (2014-08-11 23:08:25 UTC) #7
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 4 months ago (2014-08-12 00:22:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/460743002/20001
6 years, 4 months ago (2014-08-12 00:29:51 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 02:20:21 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 02:50:07 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/4640)
6 years, 4 months ago (2014-08-12 02:50:08 UTC) #12
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 4 months ago (2014-08-12 16:51:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/460743002/20001
6 years, 4 months ago (2014-08-12 16:53:27 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 17:06:46 UTC) #15
Message was sent while issue was closed.
Change committed as 289006

Powered by Google App Engine
This is Rietveld 408576698