Issue 448873002: mojo: Reland "Convert gles2 to the new thunking system."

Issue 448873002: mojo: Reland "Convert gles2 to the new thunking system." (Closed)

Created:
6 years, 4 months ago by Elliot Glaysher

Modified:
6 years, 4 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

mojo: Reland "Convert gles2 to the new thunking system." This apparently fixes the tests. There was a merge conflict with the new mojo_base.gyp file, and now we should be properly integrated, and everything needed for the implementation of GLES2 should live in mojo_base (mirroring mojo_system_impl), while everything about the thunking goes in mojo_public (mirroring mojo_system). BUG=386799 First Review URL: https://codereview.chromium.org/413303002 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288527

Patch Set 1 #

Patch Set 2 : Rebase to ToT to fix in flight collision. #

Patch Set 3 : Rebase #

Patch Set 4 : Remove hardcoded libmojo_gles2.dylib from mojo_apps_js_unittests.isolate #

Patch Set 5 : Rebase to ToT #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+471 lines, -397 lines)			Patch
M	mojo/gles2/BUILD.gn	View		1 chunk	+1 line, -2 lines	0 comments	Download
A	mojo/gles2/gles2_impl.cc	View		1 chunk	+82 lines, -0 lines	0 comments	Download
D	mojo/gles2/gles2_support_impl.h	View		1 chunk	+0 lines, -43 lines	0 comments	Download
D	mojo/gles2/gles2_support_impl.cc	View		1 chunk	+0 lines, -106 lines	0 comments	Download
M	mojo/mojo.gyp	View	1 2 3 4	5 chunks	+3 lines, -33 lines	0 comments	Download
M	mojo/mojo_apps.gypi	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	mojo/mojo_apps_js_unittests.isolate	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/mojo_base.gyp	View	1	2 chunks	+62 lines, -1 line	0 comments	Download
M	mojo/mojo_examples.gypi	View	1 2 3 4	9 chunks	+8 lines, -8 lines	0 comments	Download
M	mojo/mojo_public.gypi	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download
M	mojo/mojo_services.gypi	View	1 2 3 4	5 chunks	+5 lines, -64 lines	0 comments	Download
M	mojo/mojo_variables.gypi	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	mojo/public/c/gles2/gles2_export.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	mojo/public/gles2/BUILD.gn	View		1 chunk	+3 lines, -2 lines	0 comments	Download
D	mojo/public/gles2/gles2_private.h	View		1 chunk	+0 lines, -43 lines	0 comments	Download
D	mojo/public/gles2/gles2_private.cc	View		1 chunk	+0 lines, -80 lines	0 comments	Download
A	mojo/public/platform/native/gles2_thunks.h	View		1 chunk	+106 lines, -0 lines	0 comments	Download
A	mojo/public/platform/native/gles2_thunks.cc	View		1 chunk	+81 lines, -0 lines	0 comments	Download
M	mojo/public/platform/native/system_thunks.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download
A	mojo/public/platform/native/thunk_export.h	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	mojo/shell/context.cc	View	1 2 3 4	2 chunks	+0 lines, -2 lines	0 comments	Download
M	mojo/shell/in_process_dynamic_service_runner.cc	View		2 chunks	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

Trung: I finally figured out that the error on google chrome mac official was because ...

6 years, 4 months ago (2014-08-08 21:16:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/448873002/80001

6 years, 4 months ago (2014-08-08 22:28:54 UTC) #4

Message was sent while issue was closed.

Change committed as 288527

Expand Messages | Collapse Messages