Add print-to-file for turbofan tracing.

Add print-to-file for turbofan tracing.

BUG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23080

[Michael Starzinger, 2014-08-11 18:31:23]

https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc#new...
src/compiler/pipeline.cc:77: Vector<char> str = Vector<char>::New(256);
nit: s/str/filename/

https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc#new...
src/compiler/pipeline.cc:81: SNPrintF(str, "%s-%s.dot", name.get(), phase);
Can we get a common prefix for all of the files? That way they are nicely
grouped in any file browser and can also be easily added to the GIT ignore file.
I vote for "turbo-%s-%s.dot" as a file name.

https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc#new...
src/compiler/pipeline.cc:86: FILE* file = fopen(str.start(), "w+");
I think we will need to use base::OS::FOpen to make all platforms happy here.

[Michael Starzinger, 2014-08-11 18:42:53]

[ +v8-dev ]

[sigurds, 2014-08-12 09:24:49]

https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc#new...
src/compiler/pipeline.cc:77: Vector<char> str = Vector<char>::New(256);
On 2014/08/11 18:31:23, Michael Starzinger wrote:
> nit: s/str/filename/

Done.

https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc#new...
src/compiler/pipeline.cc:81: SNPrintF(str, "%s-%s.dot", name.get(), phase);
On 2014/08/11 18:31:23, Michael Starzinger wrote:
> Can we get a common prefix for all of the files? That way they are nicely
> grouped in any file browser and can also be easily added to the GIT ignore
file.
> I vote for "turbo-%s-%s.dot" as a file name.

Done.

https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc#new...
src/compiler/pipeline.cc:86: FILE* file = fopen(str.start(), "w+");
On 2014/08/11 18:31:23, Michael Starzinger wrote:
> I think we will need to use base::OS::FOpen to make all platforms happy here.

Done.

[Michael Starzinger, 2014-08-12 12:32:00]

LGTM.

[sigurds, 2014-08-12 13:09:15]

Committed patchset #2 manually as 23080 (presubmit successful).