Add print-to-file for turbofan tracing.

src/compiler/pipeline.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/pipeline.h"
 
 #include "src/base/platform/elapsed-timer.h"
 #include "src/compiler/ast-graph-builder.h"
 #include "src/compiler/code-generator.h"
 #include "src/compiler/graph-replay.h"
 #include "src/compiler/graph-visualizer.h"
 #include "src/compiler/instruction.h"
 #include "src/compiler/instruction-selector.h"
 #include "src/compiler/js-context-specialization.h"
 #include "src/compiler/js-generic-lowering.h"
 #include "src/compiler/js-typed-lowering.h"
 #include "src/compiler/register-allocator.h"
 #include "src/compiler/schedule.h"
 #include "src/compiler/scheduler.h"
 #include "src/compiler/simplified-lowering.h"
 #include "src/compiler/typer.h"
 #include "src/compiler/verifier.h"
 #include "src/hydrogen.h"
 #include "src/ostreams.h"
+#include "src/utils.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 class PhaseStats {
  public:
   enum PhaseKind { CREATE_GRAPH, OPTIMIZATION, CODEGEN };
 
   PhaseStats(CompilationInfo* info, PhaseKind kind, const char* name)
@@ skipping 31 matching lines @@
   CompilationInfo* info_;
   PhaseKind kind_;
   const char* name_;
   size_t size_;
   base::ElapsedTimer timer_;
 };
 
 
 void Pipeline::VerifyAndPrintGraph(Graph* graph, const char* phase) {
   if (FLAG_trace_turbo) {
+    Vector<char> str = Vector<char>::New(256);

[Michael Starzinger, 2014/08/11 18:31:23]

nit: s/str/filename/

[sigurds, 2014/08/12 09:24:49]

Done.

+    SmartArrayPointer<char> name =
+        info_->shared_info()->DebugName()->ToCString();
+    if (strlen(name.get()) > 0) {
+      SNPrintF(str, "%s-%s.dot", name.get(), phase);

[Michael Starzinger, 2014/08/11 18:31:23]

Can we get a common prefix for all of the files? That way they are nicely
grouped in any file browser and can also be easily added to the GIT ignore file.
I vote for "turbo-%s-%s.dot" as a file name.

[sigurds, 2014/08/12 09:24:49]

Done.

+    } else {
+      SNPrintF(str, "%p-%s.dot", static_cast<void*>(info_), phase);
+    }
+    std::replace(str.start(), str.start() + str.length(), ' ', '_');
+    FILE* file = fopen(str.start(), "w+");

[Michael Starzinger, 2014/08/11 18:31:23]

I think we will need to use base::OS::FOpen to make all platforms happy here.

[sigurds, 2014/08/12 09:24:49]

Done.

+    OFStream of(file);
+    of << AsDOT(*graph);
+    fclose(file);
+
     OFStream os(stdout);
-    os << "-- " << phase << " graph -----------------------------------\n"
-       << AsDOT(*graph);
+    os << "-- " << phase << " graph printed to file " << str.start() << "\n";
   }
   if (VerifyGraphs()) Verifier::Run(graph);
 }
 
 
 class AstGraphBuilderWithPositions : public AstGraphBuilder {
  public:
   explicit AstGraphBuilderWithPositions(CompilationInfo* info, JSGraph* jsgraph,
                                         SourcePositionTable* source_positions)
       : AstGraphBuilder(info, jsgraph), source_positions_(source_positions) {}
@@ skipping 214 matching lines @@
 }
 
 
 void Pipeline::TearDown() {
   InstructionOperand::TearDownCaches();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8