Fix bug in caching of chunked transfer encoding in HTTP headers

sdk/lib/io/http_headers.dart

Index: sdk/lib/io/http_headers.dart
diff --git a/sdk/lib/io/http_headers.dart b/sdk/lib/io/http_headers.dart
index f621fff07fa1fc8e4246393737fc110480e49b4d..ce19a531112ee5d5468b13601d879a3b78aa26df 100644
--- a/sdk/lib/io/http_headers.dart
+++ b/sdk/lib/io/http_headers.dart
@@ -60,6 +60,9 @@ class _HttpHeaders implements HttpHeaders {
     _checkMutable();
     name = _validateField(name);
     _headers.remove(name);
+    if (name == HttpHeaders.TRANSFER_ENCODING) {

[Anders Johnsen, 2014/08/11 12:39:55]

This should hit the _add switch below, right?

[Søren Gjesse, 2014/08/11 14:20:49]

The problem is that the logic invoked by _add will check the current value of
_chunkedTransferEncoding to see if there was changes.

[Anders Johnsen, 2014/08/12 05:42:38]

I see. We should probably rewrite this logic at some point, to handle all of
add/set/remove.

[Søren Gjesse, 2014/08/12 06:38:33]

That we can absolutely agree on :-)

+      _chunkedTransferEncoding = false;
+    }
     _addAll(name, value);
   }
 
@@ -75,6 +78,9 @@ class _HttpHeaders implements HttpHeaders {
       }
       if (values.length == 0) _headers.remove(name);
     }

[Anders Johnsen, 2014/08/11 12:39:56]

Ditto.

[Søren Gjesse, 2014/08/11 14:20:49]

This code never calls the _add code.

[Anders Johnsen, 2014/08/12 05:42:38]

Right!

+    if (name == HttpHeaders.TRANSFER_ENCODING && value == "chunked") {
+      _chunkedTransferEncoding = false;
+    }
   }
 
   void removeAll(String name) {