Fix bug in caching of chunked transfer encoding in HTTP headers

sdk/lib/io/http_headers.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 class _HttpHeaders implements HttpHeaders {
   final Map<String, List<String>> _headers;
   final String protocolVersion;
 
@@ skipping 42 matching lines @@
       }
     } else {
       _add(name, _validateValue(value));
     }
   }
 
   void set(String name, Object value) {
     _checkMutable();
     name = _validateField(name);
     _headers.remove(name);
+    if (name == HttpHeaders.TRANSFER_ENCODING) {

[Anders Johnsen, 2014/08/11 12:39:55]

This should hit the _add switch below, right?

[Søren Gjesse, 2014/08/11 14:20:49]

The problem is that the logic invoked by _add will check the current value of
_chunkedTransferEncoding to see if there was changes.

[Anders Johnsen, 2014/08/12 05:42:38]

I see. We should probably rewrite this logic at some point, to handle all of
add/set/remove.

[Søren Gjesse, 2014/08/12 06:38:33]

That we can absolutely agree on :-)

+      _chunkedTransferEncoding = false;
+    }
     _addAll(name, value);
   }
 
   void remove(String name, Object value) {
     _checkMutable();
     name = _validateField(name);
     value = _validateValue(value);
     List<String> values = _headers[name];
     if (values != null) {
       int index = values.indexOf(value);
       if (index != -1) {
         values.removeRange(index, index + 1);
       }
       if (values.length == 0) _headers.remove(name);
     }

[Anders Johnsen, 2014/08/11 12:39:56]

Ditto.

[Søren Gjesse, 2014/08/11 14:20:49]

This code never calls the _add code.

[Anders Johnsen, 2014/08/12 05:42:38]

Right!

+    if (name == HttpHeaders.TRANSFER_ENCODING && value == "chunked") {
+      _chunkedTransferEncoding = false;
+    }
   }
 
   void removeAll(String name) {
     _checkMutable();
     name = _validateField(name);
     _headers.remove(name);
   }
 
   void forEach(void f(String name, List<String> values)) {
     _headers.forEach(f);
@@ skipping 847 matching lines @@
             (codeUnit >= 0x23 && codeUnit <= 0x2B) ||
             (codeUnit >= 0x2D && codeUnit <= 0x3A) ||
             (codeUnit >= 0x3C && codeUnit <= 0x5B) ||
             (codeUnit >= 0x5D && codeUnit <= 0x7E))) {
         throw new FormatException(
             "Invalid character in cookie value, code unit: '$codeUnit'");
       }
     }
   }
 }