Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java

Issue 460453002: Fixed Compilation issues related to API Level of Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed SuppressLint for ClickableViewAccessibility. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java b/content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java
index bdc54301f220634ee7b909287a4de79908ca697d..57bde1d08e50a42aaf959356254c6c00223596c1 100644
--- a/content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java
+++ b/content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java
@@ -533,8 +533,16 @@ class PopupZoomer extends View {
}
@Override
+ public boolean performClick() {
+ return super.performClick();
aurimas (slooooooooow) 2014/08/12 15:59:44 Why do we need this override? It just calls super.
AKVT 2014/08/12 16:22:40 This is to tackle overrides onTouchEvent but not p
+ }
+
+ @Override
public boolean onTouchEvent(MotionEvent event) {
mGestureDetector.onTouchEvent(event);
+ if (event.getAction() == MotionEvent.ACTION_UP) {
+ performClick();
aurimas (slooooooooow) 2014/08/12 16:30:21 I guess I did not explain it well. Why don't we ca
+ }
return true;
}

Powered by Google App Engine
This is Rietveld 408576698