Issue 46043020: [Object.observe] rename intrinsic change record types for consitency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 46043020: [Object.observe] rename intrinsic change record types for consitency. (Closed)

Created:
7 years, 1 month ago by rafaelw

Modified:
7 years, 1 month ago

Reviewers:
rossberg

CC:
v8-dev, arv (Not doing code reviews), adamk

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

[Object.observe] rename intrinsic change record types for consitency. Note the spec now reflects the updated naming: http://wiki.ecmascript.org/doku.php?id=harmony:observe_spec_changes R=rossberg@chromium.org, rossberg BUG=v8:2940 Committed: https://code.google.com/p/v8/source/detail?r=17520

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+328 lines, -328 lines)			Patch
M	src/accessors.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/object-observe.js	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/objects.cc	View	1	9 chunks	+18 lines, -18 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-object-observe.cc	View		7 chunks	+33 lines, -33 lines	0 comments	Download
M	test/mjsunit/harmony/object-observe.js	View	1	45 chunks	+267 lines, -267 lines	0 comments	Download

Total messages: 3 (0 generated)

rafaelw

7 years, 1 month ago (2013-11-06 12:14:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17520 (presubmit successful).