Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: src/accessors.cc

Issue 46043020: [Object.observe] rename intrinsic change record types for consitency. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: sync Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/object-observe.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 old_value = handle(function->prototype(), isolate); 610 old_value = handle(function->prototype(), isolate);
611 else 611 else
612 old_value = isolate->factory()->NewFunctionPrototype(function); 612 old_value = isolate->factory()->NewFunctionPrototype(function);
613 } 613 }
614 614
615 JSFunction::SetPrototype(function, value); 615 JSFunction::SetPrototype(function, value);
616 ASSERT(function->prototype() == *value); 616 ASSERT(function->prototype() == *value);
617 617
618 if (is_observed && !old_value->SameValue(*value)) { 618 if (is_observed && !old_value->SameValue(*value)) {
619 JSObject::EnqueueChangeRecord( 619 JSObject::EnqueueChangeRecord(
620 function, "updated", isolate->factory()->prototype_string(), old_value); 620 function, "update", isolate->factory()->prototype_string(), old_value);
621 } 621 }
622 622
623 return *function; 623 return *function;
624 } 624 }
625 625
626 626
627 const AccessorDescriptor Accessors::FunctionPrototype = { 627 const AccessorDescriptor Accessors::FunctionPrototype = {
628 FunctionGetPrototype, 628 FunctionGetPrototype,
629 FunctionSetPrototype, 629 FunctionSetPrototype,
630 0 630 0
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
968 info->set_data(Smi::FromInt(index)); 968 info->set_data(Smi::FromInt(index));
969 Handle<Object> getter = v8::FromCData(isolate, &ModuleGetExport); 969 Handle<Object> getter = v8::FromCData(isolate, &ModuleGetExport);
970 Handle<Object> setter = v8::FromCData(isolate, &ModuleSetExport); 970 Handle<Object> setter = v8::FromCData(isolate, &ModuleSetExport);
971 info->set_getter(*getter); 971 info->set_getter(*getter);
972 if (!(attributes & ReadOnly)) info->set_setter(*setter); 972 if (!(attributes & ReadOnly)) info->set_setter(*setter);
973 return info; 973 return info;
974 } 974 }
975 975
976 976
977 } } // namespace v8::internal 977 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/object-observe.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698