Issue 460313002: No chrome dependencies in KeywordProvider

Issue 460313002: No chrome dependencies in KeywordProvider (Closed)

Created:
6 years, 4 months ago by hashimoto

Modified:
6 years, 4 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, James Su, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

No chrome dependencies in KeywordProvider Profile related business is handled by KeywordExtensionsDelegateImpl. BUG=388515 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289248

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename setter #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -64 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_controller.cc	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/keyword_extensions_delegate.h	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/keyword_extensions_delegate.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/keyword_extensions_delegate_impl.h	View		3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/keyword_extensions_delegate_impl.cc	View		7 chunks	+13 lines, -12 lines	0 comments	Download
M	chrome/browser/autocomplete/keyword_provider.h	View	1	3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/autocomplete/keyword_provider.cc	View	1	6 chunks	+9 lines, -35 lines	0 comments	Download
M	chrome/browser/autocomplete/keyword_provider_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM https://codereview.chromium.org/460313002/diff/1/chrome/browser/autocomplete/keyword_provider.cc File chrome/browser/autocomplete/keyword_provider.cc (right): https://codereview.chromium.org/460313002/diff/1/chrome/browser/autocomplete/keyword_provider.cc#newcode82 chrome/browser/autocomplete/keyword_provider.cc:82: extensions_delegate_ = extensions_delegate.Pass(); Nit: This could probably be ...

6 years, 4 months ago (2014-08-12 18:24:12 UTC) #2

hashimoto

https://codereview.chromium.org/460313002/diff/1/chrome/browser/autocomplete/keyword_provider.cc File chrome/browser/autocomplete/keyword_provider.cc (right): https://codereview.chromium.org/460313002/diff/1/chrome/browser/autocomplete/keyword_provider.cc#newcode82 chrome/browser/autocomplete/keyword_provider.cc:82: extensions_delegate_ = extensions_delegate.Pass(); On 2014/08/12 18:24:11, Peter Kasting wrote: ...

6 years, 4 months ago (2014-08-13 02:22:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/460313002/20001

6 years, 4 months ago (2014-08-13 02:26:05 UTC) #5

Message was sent while issue was closed.

Change committed as 289248

Expand Messages | Collapse Messages