Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: chrome/browser/autocomplete/keyword_provider.cc

Issue 460313002: No chrome dependencies in KeywordProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename setter Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/keyword_provider.cc
diff --git a/chrome/browser/autocomplete/keyword_provider.cc b/chrome/browser/autocomplete/keyword_provider.cc
index 0d590ed202182ab6e0e5a87c8b7abf6983893fed..b97b847777968fc92c548372b18c246c3ce0cde2 100644
--- a/chrome/browser/autocomplete/keyword_provider.cc
+++ b/chrome/browser/autocomplete/keyword_provider.cc
@@ -11,26 +11,16 @@
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/autocomplete/keyword_extensions_delegate.h"
-#include "chrome/browser/chrome_notification_types.h"
-#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/search_engines/template_url_service_factory.h"
#include "components/metrics/proto/omnibox_input_type.pb.h"
#include "components/omnibox/autocomplete_match.h"
#include "components/omnibox/autocomplete_provider_listener.h"
#include "components/search_engines/template_url.h"
#include "components/search_engines/template_url_service.h"
-#include "content/public/browser/notification_details.h"
-#include "content/public/browser/notification_source.h"
-#include "extensions/browser/extension_system.h"
#include "grit/generated_resources.h"
#include "net/base/escape.h"
#include "net/base/net_util.h"
#include "ui/base/l10n/l10n_util.h"
-#if defined(ENABLE_EXTENSIONS)
-#include "chrome/browser/autocomplete/keyword_extensions_delegate_impl.h"
-#endif
-
namespace {
// Helper functor for Start(), for sorting keyword matches by quality.
@@ -79,22 +69,11 @@ void ScopedEndExtensionKeywordMode::StayInKeywordMode() {
} // namespace
-KeywordProvider::KeywordProvider(AutocompleteProviderListener* listener,
- Profile* profile)
- : AutocompleteProvider(AutocompleteProvider::TYPE_KEYWORD),
- listener_(listener),
- profile_(profile),
- model_(NULL) {
-#if defined(ENABLE_EXTENSIONS)
- extensions_delegate_.reset(new KeywordExtensionsDelegateImpl(this));
-#endif
-}
-
-KeywordProvider::KeywordProvider(AutocompleteProviderListener* listener,
- TemplateURLService* model)
+KeywordProvider::KeywordProvider(
+ AutocompleteProviderListener* listener,
+ TemplateURLService* model)
: AutocompleteProvider(AutocompleteProvider::TYPE_KEYWORD),
listener_(listener),
- profile_(NULL),
model_(model) {
}
@@ -203,8 +182,7 @@ base::string16 KeywordProvider::GetKeywordForText(
// Don't provide a keyword for inactive/disabled extension keywords.
if ((template_url->GetType() == TemplateURL::OMNIBOX_API_EXTENSION) &&
extensions_delegate_ &&
- !extensions_delegate_->IsEnabledExtension(
- profile_, template_url->GetExtensionId()))
+ !extensions_delegate_->IsEnabledExtension(template_url->GetExtensionId()))
return base::string16();
return keyword;
@@ -270,11 +248,10 @@ void KeywordProvider::Start(const AutocompleteInput& input,
// Prune any extension keywords that are disallowed in incognito mode (if
// we're incognito), or disabled.
- if (profile_ &&
- (template_url->GetType() == TemplateURL::OMNIBOX_API_EXTENSION) &&
+ if (template_url->GetType() == TemplateURL::OMNIBOX_API_EXTENSION &&
extensions_delegate_ &&
!extensions_delegate_->IsEnabledExtension(
- profile_, template_url->GetExtensionId())) {
+ template_url->GetExtensionId())) {
i = matches.erase(i);
continue;
}
@@ -320,7 +297,7 @@ void KeywordProvider::Start(const AutocompleteInput& input,
matches_.push_back(CreateAutocompleteMatch(
template_url, input, keyword.length(), remaining_input, true, -1));
- if (profile_ && is_extension_keyword && extensions_delegate_) {
+ if (is_extension_keyword && extensions_delegate_) {
if (extensions_delegate_->Start(input, minimal_changes, template_url,
remaining_input))
keyword_mode_toggle.StayInKeywordMode();
@@ -487,11 +464,8 @@ void KeywordProvider::FillInURLAndContents(
}
TemplateURLService* KeywordProvider::GetTemplateURLService() const {
- TemplateURLService* service = profile_ ?
- TemplateURLServiceFactory::GetForProfile(profile_) : model_;
// Make sure the model is loaded. This is cheap and quickly bails out if
// the model is already loaded.
- DCHECK(service);
- service->Load();
- return service;
+ model_->Load();
+ return model_;
}
« no previous file with comments | « chrome/browser/autocomplete/keyword_provider.h ('k') | chrome/browser/autocomplete/keyword_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698