third_party/closure_compiler/README.chromium - Issue 460163002: Handle property definition by {cr|Object}.defineProperty() in compiler pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/README.chromium

Issue 460163002: Handle property definition by {cr|Object}.defineProperty() in compiler pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@C_compiler_pass

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/closure_compiler/compiler_customization_test.py » ('j') | third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/closure_compiler/README.chromium

diff --git a/third_party/closure_compiler/README.chromium b/third_party/closure_compiler/README.chromium

index 1884c402c85bca90d18f5aecd40210eb187bfc20..20f6d3890aad5e254c5fbf670a0f65da84537319 100644

--- a/third_party/closure_compiler/README.chromium

+++ b/third_party/closure_compiler/README.chromium

@@ -18,6 +18,7 @@ Local modifications:

compiler to "IDE mode" (single-file checks, doesn't stop on first error).

- Chrome-specific coding conventions to understand cr.addSingletonGetter().

- third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java

- Added pass to handle Chrome-specific namespace creation with cr.define()

+ Added pass to handle namespace definition with cr.define() and property

+ definition with {cr|Object}.defineProperty().

See third_party/closure_compiler/runner/how_to_test_compiler_pass.md for

testing instructions on this pass.