third_party/closure_compiler/README.chromium - Issue 460163002: Handle property definition by {cr|Object}.defineProperty() in compiler pass

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/closure_compiler/README.chromium

Issue 460163002: Handle property definition by {cr|Object}.defineProperty() in compiler pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@C_compiler_pass

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/closure_compiler/compiler_customization_test.py » ('j') | third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Name: Closure compiler	1 Name: Closure compiler

2 Short Name: closure-compiler	2 Short Name: closure-compiler

3 URL: https://developers.google.com/closure/compiler/	3 URL: https://developers.google.com/closure/compiler/

4 Version: v20140508-220-g8b4b812	4 Version: v20140508-220-g8b4b812

5 Date: 2014/06/20 12:20	5 Date: 2014/06/20 12:20

6 Revision: g8b4b812	6 Revision: g8b4b812

7 License: Apache 2.0	7 License: Apache 2.0

8 License File: LICENSE	8 License File: LICENSE

9 Security Critical: no	9 Security Critical: no

10	10

11 Description:	11 Description:

12 The Closure Compiler provides warnings for illegal JavaScript and warnings for	12 The Closure Compiler provides warnings for illegal JavaScript and warnings for

13 potentially dangerous operations, helping you to produce JavaScript that is less	13 potentially dangerous operations, helping you to produce JavaScript that is less

14 buggy and easier to maintain.	14 buggy and easier to maintain.

15	15

16 Local modifications:	16 Local modifications:

17 - The compiler is run via a custom mechanism (see: runner/) that sets the	17 - The compiler is run via a custom mechanism (see: runner/) that sets the

18 compiler to "IDE mode" (single-file checks, doesn't stop on first error).	18 compiler to "IDE mode" (single-file checks, doesn't stop on first error).

19 - Chrome-specific coding conventions to understand cr.addSingletonGetter().	19 - Chrome-specific coding conventions to understand cr.addSingletonGetter().

20 - third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePas s.java	20 - third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePas s.java

21 Added pass to handle Chrome-specific namespace creation with cr.define()	21 Added pass to handle namespace definition with cr.define() and property

	22 definition with {cr\|Object}.defineProperty().

22 See third_party/closure_compiler/runner/how_to_test_compiler_pass.md for	23 See third_party/closure_compiler/runner/how_to_test_compiler_pass.md for

23 testing instructions on this pass.	24 testing instructions on this pass.

OLD	NEW