Allow passing parameters within appview

Allow passing parameters within appview

BUG=239656
Review URL: https://codereview.chromium.org/287153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271719 0039d316-1c4b-4281-b951-d872f2087c98

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289503

[Xi Han, 2014-08-12 18:52:19]

https://codereview.chromium.org/460133002/diff/20001/chrome/test/data/extensi...
File chrome/test/data/extensions/platform_apps/app_view/shim/main.js (right):

https://codereview.chromium.org/460133002/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/platform_apps/app_view/shim/main.js:110:
appview.connect(appToEmbed, { 'foo': 'bleep' }, function(success) {
I think the step 2 shouldn't be a part of the callback of the first
appview.connect(...) function. It would be better if we make it as a independent
test. Also, the LOG of the step 2 is missing.

https://codereview.chromium.org/460133002/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/platform_apps/app_view/shim/main.js:124:
'testAppViewParams': testAppViewParams
Maybe we can split the second test as two, like:
testAppViewWithRefusedParamsShouldFail,
testAppViewWithGoodParamsShouldSucceed.

[Fady Samuel, 2014-08-13 21:07:01]

PTAL

[Xi Han, 2014-08-13 21:11:48]

lgtm

[Fady Samuel, 2014-08-13 21:12:45]

+kalman@: Please take a look at app_runtime.idl.

[not at google - send to devlin, 2014-08-13 23:23:08]

lgtm

https://codereview.chromium.org/460133002/diff/40001/extensions/common/api/ap...
File extensions/common/api/app_runtime.idl (right):

https://codereview.chromium.org/460133002/diff/40001/extensions/common/api/ap...
extensions/common/api/app_runtime.idl:52: any params;
If I'm to nit, I don't think "params" is the right term here since it's not a
function. Perhaps "data"?

Also, comment.

[Fady Samuel, 2014-08-13 23:42:04]

CQ'ing

https://codereview.chromium.org/460133002/diff/40001/extensions/common/api/ap...
File extensions/common/api/app_runtime.idl (right):

https://codereview.chromium.org/460133002/diff/40001/extensions/common/api/ap...
extensions/common/api/app_runtime.idl:52: any params;
On 2014/08/13 23:23:08, kalman wrote:
> If I'm to nit, I don't think "params" is the right term here since it's not a
> function. Perhaps "data"?
> 
> Also, comment.

Done.

[Fady Samuel, 2014-08-13 23:42:05]

CQ'ing

[Fady Samuel, 2014-08-13 23:42:09]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-08-13 23:45:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fsamuel@chromium.org/460133002/60001

[commit-bot: I haz the power, 2014-08-14 05:49:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-14 09:46:59]

Committed patchset #4 (60001) as 289503