Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 287153006: Pepper: Manifest refactoring in trusted plugin. (Closed)

Created:
6 years, 7 months ago by teravest
Modified:
6 years, 7 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Visibility:
Public.

Description

Pepper: Manifest refactoring in trusted plugin. This lifts more manifest processing code out of the trusted plugin. Specifically, instead of the trusted plugin receiving a PP_Var with the contents of the manifest and making another method to create the manifest id, the trusted plugin now simply receives the manifest ID directly. BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271719

Patch Set 1 : build fix #

Patch Set 2 : Remove more vestigal code #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -93 lines) Patch
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 2 9 chunks +22 lines, -16 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 1 2 3 chunks +0 lines, -11 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 1 2 5 chunks +4 lines, -48 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
teravest
6 years, 7 months ago (2014-05-16 19:13:49 UTC) #1
teravest
Mind taking a look at this?
6 years, 7 months ago (2014-05-19 18:17:28 UTC) #2
dmichael (off chromium)
lgtm
6 years, 7 months ago (2014-05-19 19:38:14 UTC) #3
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 7 months ago (2014-05-19 19:49:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/287153006/90001
6 years, 7 months ago (2014-05-19 19:50:03 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 21:02:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 03:46:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/17632)
6 years, 7 months ago (2014-05-20 03:46:55 UTC) #8
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 7 months ago (2014-05-20 14:10:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/287153006/90001
6 years, 7 months ago (2014-05-20 14:10:50 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 18:44:16 UTC) #11
Message was sent while issue was closed.
Change committed as 271719

Powered by Google App Engine
This is Rietveld 408576698