Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 460123002: Update the path to profile_chrome.py (Closed)

Created:
6 years, 4 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 4 months ago
Reviewers:
Sami, alokp
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update the path to profile_chrome.py In the CL commit 46d8f4c5dc5a1081a7e842ad28e4deea9c1736b7 Author: alokp@chromium.org <alokp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>; Date: Fri Jul 18 21:36:55 2014 +0000 Move adb_profile_chrome to profile_chrome. This is being done with the intention to port this tool to other platforms. The first step is to move the existing code to a common location. Review URL: https://codereview.chromium.org/402803005 We moved adb_profile_chrome to a new location, update its path in android_systrace_profiler.py accordingly. BUG=None TEST=run benchmark with --profiler=android-systrace and no complaining of can't find adb_profile_chrome Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yufeng Shen (Slow to review)
6 years, 4 months ago (2014-08-11 22:40:31 UTC) #1
Yufeng Shen (Slow to review)
6 years, 4 months ago (2014-08-11 22:40:33 UTC) #2
Yufeng Shen (Slow to review)
6 years, 4 months ago (2014-08-11 22:40:35 UTC) #3
Sami
lgtm, sorry for overlooking this.
6 years, 4 months ago (2014-08-12 11:03:14 UTC) #4
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 4 months ago (2014-08-12 16:15:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/460123002/1
6 years, 4 months ago (2014-08-12 16:17:35 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-12 21:29:55 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 01:02:51 UTC) #8
Message was sent while issue was closed.
Change committed as 289140

Powered by Google App Engine
This is Rietveld 408576698