Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 402803005: Move adb_profile_chrome to profile_chrome. (Closed)

Created:
6 years, 5 months ago by alokp
Modified:
6 years, 5 months ago
Reviewers:
nduca, Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move adb_profile_chrome to profile_chrome. This is being done with the intention to port this tool to other platforms. The first step is to move the existing code to a common location. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284207

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1185 lines) Patch
M build/android/adb_profile_chrome View 1 chunk +1 line, -1 line 0 comments Download
D tools/android/adb_profile_chrome.py View 1 chunk +0 lines, -13 lines 0 comments Download
D tools/android/adb_profile_chrome/__init__.py View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/android/adb_profile_chrome/chrome_controller.py View 1 chunk +0 lines, -102 lines 0 comments Download
D tools/android/adb_profile_chrome/chrome_controller_unittest.py View 1 chunk +0 lines, -46 lines 0 comments Download
D tools/android/adb_profile_chrome/controllers.py View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/android/adb_profile_chrome/controllers_unittest.py View 1 chunk +0 lines, -24 lines 0 comments Download
D tools/android/adb_profile_chrome/main.py View 1 chunk +0 lines, -250 lines 0 comments Download
D tools/android/adb_profile_chrome/perf_controller.py View 1 2 1 chunk +0 lines, -187 lines 0 comments Download
D tools/android/adb_profile_chrome/perf_controller_unittest.py View 1 chunk +0 lines, -50 lines 0 comments Download
D tools/android/adb_profile_chrome/profiler.py View 1 chunk +0 lines, -87 lines 0 comments Download
D tools/android/adb_profile_chrome/profiler_unittest.py View 1 chunk +0 lines, -78 lines 0 comments Download
D tools/android/adb_profile_chrome/run_tests View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/android/adb_profile_chrome/systrace_controller.py View 1 chunk +0 lines, -95 lines 0 comments Download
D tools/android/adb_profile_chrome/systrace_controller_unittest.py View 1 chunk +0 lines, -36 lines 0 comments Download
D tools/android/adb_profile_chrome/trace_packager.py View 1 chunk +0 lines, -94 lines 0 comments Download
D tools/android/adb_profile_chrome/trace_packager_unittest.py View 1 chunk +0 lines, -35 lines 0 comments Download
D tools/android/adb_profile_chrome/ui.py View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/android/adb_profile_chrome/util.py View 1 chunk +0 lines, -8 lines 0 comments Download
A + tools/profile_chrome.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/profile_chrome/__init__.py View 1 1 chunk +4 lines, -1 line 0 comments Download
A + tools/profile_chrome/chrome_controller.py View 1 chunk +2 lines, -1 line 0 comments Download
A + tools/profile_chrome/chrome_controller_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/profile_chrome/controllers.py View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/profile_chrome/controllers_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/profile_chrome/main.py View 1 chunk +5 lines, -5 lines 0 comments Download
A + tools/profile_chrome/perf_controller.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/profile_chrome/perf_controller_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + tools/profile_chrome/profiler.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/profile_chrome/profiler_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
A tools/profile_chrome/run_tests View 1 chunk +3 lines, -0 lines 0 comments Download
A + tools/profile_chrome/systrace_controller.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/profile_chrome/systrace_controller_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/profile_chrome/trace_packager.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/profile_chrome/trace_packager_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/profile_chrome/ui.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/profile_chrome/util.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alokp
6 years, 5 months ago (2014-07-17 22:24:22 UTC) #1
Sami
Thanks Alok, lgtm.
6 years, 5 months ago (2014-07-18 12:49:57 UTC) #2
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 5 months ago (2014-07-18 17:38:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/402803005/40001
6 years, 5 months ago (2014-07-18 17:40:19 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 21:36:58 UTC) #5
Message was sent while issue was closed. 
Change committed as 284207

Powered by Google App Engine
This is Rietveld 408576698