Issue 460101: Mac: fix problem with un-minimizing windows using the app icon in the Dock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460101: Mac: fix problem with un-minimizing windows using the app icon in the Dock. (Closed)

Created:
11 years ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
pink (ping after 24hrs), Nico

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: fix problem with un-minimizing windows using the app icon in the Dock. More specifically, when detaching the status bubble window, don't just remove it as a child window but also remove it from the screen list. BUG=29054 TEST=Minimize all browser windows and make sure clicking on the app's Dock icon restores (un-minimizes) the last-used browser window; repeat under a variety of circumstances; see bug for more details. Also make sure that the status bubble continues to work properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33955

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/status_bubble_mac.mm	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

11 years ago (2009-12-07 06:18:42 UTC) #3

Thanks. Committing now so that perhaps it'll make it in time for the nightly
build.

Given how extremely imminent beta is, I don't think it'd make it (*), though I'd
otherwise be supportive. Sigh. Given how many dupes of the bug report have
already been filed, I'm getting my asbestos underwear ready.

(*) My understanding of the beta is that we'll just be picking a suitably-good
(249-based) dev channel and going with that.

On 2009/12/07 05:22:39, Nico wrote:
> LG.
> 
> s/the it/it/ in description.
> 
> Maybe merge to m4?

Expand Messages | Collapse Messages