Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5329)

Unified Diff: chrome/browser/cocoa/status_bubble_mac.mm

Issue 460101: Mac: fix problem with un-minimizing windows using the app icon in the Dock. (Closed)
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/status_bubble_mac.mm
diff --git a/chrome/browser/cocoa/status_bubble_mac.mm b/chrome/browser/cocoa/status_bubble_mac.mm
index daea726f00c9a22a7642c480e95981f29404dfb8..c511253915a36e47d3ff0e13632db9fce7797830 100644
--- a/chrome/browser/cocoa/status_bubble_mac.mm
+++ b/chrome/browser/cocoa/status_bubble_mac.mm
@@ -350,8 +350,10 @@ void StatusBubbleMac::Attach() {
void StatusBubbleMac::Detach() {
// This method may be called several times in the process of hiding or
// destroying a status bubble.
- if (is_attached())
- [parent_ removeChildWindow:window_];
+ if (is_attached()) {
+ [parent_ removeChildWindow:window_]; // See crbug.com/28107 ...
+ [window_ orderOut:nil]; // ... and crbug.com/29054.
+ }
}
void StatusBubbleMac::AnimationDidStop(CAAnimation* animation, bool finished) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698