Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: Tools/GardeningServer/model/ct-failure.html

Issue 459983002: Kill ui.js (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/model/ct-failure.html
diff --git a/Tools/GardeningServer/model/ct-failure.html b/Tools/GardeningServer/model/ct-failure.html
index d007fe1d6b0f90650dbacddc8380d640e4a52140..01fe53b893c2d4070c3b942165c5fb7506ef4095 100644
--- a/Tools/GardeningServer/model/ct-failure.html
+++ b/Tools/GardeningServer/model/ct-failure.html
@@ -14,4 +14,33 @@ function CTFailure(step, reason, resultsByBuilder, firstFailingRevisions, lastPa
this.firstFailingRevisions = firstFailingRevisions;
this.lastPassingRevisions = lastPassingRevisions;
}
+
+CTFailure.prototype.urlForFlakinessDashboard = function(tree) {
ojan 2014/08/11 19:30:08 Nit: While we're moving it, how about we give it a
+ var testType = this.step;
+
+ // FIXME: Replace the flakiness dashboard's sense of groups with sheriff-o-matic's
ojan 2014/08/11 19:30:08 This fixme is now to get rid of the flakiness dash
+ // sense of trees and get rid of this mapping.
+ var treeToDashboardGroup = {
+ blink: '@ToT%20Blink',
+ chromium: '@ToT%20Chromium',
+ };
+
+ // FIXME: Remove this once the flakiness dashboard stops having webkit_tests
+ // masquerade as layout-tests.
+ if (testType == 'webkit_tests')
+ testType = 'layout-tests';
+
+ // FIXME: sugarjs's toQueryString makes spaces into pluses instead of %20, which confuses
+ // the flakiness dashboard, which just uses decodeURIComponent.
+ return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=' +
+ treeToDashboardGroup[tree] + '&' +
+ Object.toQueryString({
+ tests: this.testName,
+ testType: testType,
+ });
+}
+
+CTFailure.prototype.urlForEmbeddedFlakinessDashboard = function(tree) {
+ return this.urlForFlakinessDashboard(tree) + '&showChrome=false';
+}
</script>
« no previous file with comments | « no previous file | Tools/GardeningServer/run-unittests.html » ('j') | Tools/GardeningServer/ui/ct-results-by-builder.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698