Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: Tools/GardeningServer/model/ct-failure.html

Issue 459983002: Kill ui.js (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <!-- 1 <!--
2 Copyright 2014 The Chromium Authors. All rights reserved. 2 Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <script> 7 <script>
8 function CTFailure(step, reason, resultsByBuilder, firstFailingRevisions, lastPa ssingRevisions) { 8 function CTFailure(step, reason, resultsByBuilder, firstFailingRevisions, lastPa ssingRevisions) {
9 this.step = step; 9 this.step = step;
10 // FIXME: Rename this to reason. 10 // FIXME: Rename this to reason.
11 this.testName = reason; 11 this.testName = reason;
12 this.resultNodesByBuilder = resultsByBuilder; 12 this.resultNodesByBuilder = resultsByBuilder;
13 // FIXME: Move these up one layer to the groupedFailures object. 13 // FIXME: Move these up one layer to the groupedFailures object.
14 this.firstFailingRevisions = firstFailingRevisions; 14 this.firstFailingRevisions = firstFailingRevisions;
15 this.lastPassingRevisions = lastPassingRevisions; 15 this.lastPassingRevisions = lastPassingRevisions;
16 } 16 }
17
18 CTFailure.prototype.urlForFlakinessDashboard = function(tree) {
ojan 2014/08/11 19:30:08 Nit: While we're moving it, how about we give it a
19 var testType = this.step;
20
21 // FIXME: Replace the flakiness dashboard's sense of groups with sheriff-o-mat ic's
ojan 2014/08/11 19:30:08 This fixme is now to get rid of the flakiness dash
22 // sense of trees and get rid of this mapping.
23 var treeToDashboardGroup = {
24 blink: '@ToT%20Blink',
25 chromium: '@ToT%20Chromium',
26 };
27
28 // FIXME: Remove this once the flakiness dashboard stops having webkit_tests
29 // masquerade as layout-tests.
30 if (testType == 'webkit_tests')
31 testType = 'layout-tests';
32
33 // FIXME: sugarjs's toQueryString makes spaces into pluses instead of %20, whi ch confuses
34 // the flakiness dashboard, which just uses decodeURIComponent.
35 return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html#gr oup=' +
36 treeToDashboardGroup[tree] + '&' +
37 Object.toQueryString({
38 tests: this.testName,
39 testType: testType,
40 });
41 }
42
43 CTFailure.prototype.urlForEmbeddedFlakinessDashboard = function(tree) {
44 return this.urlForFlakinessDashboard(tree) + '&showChrome=false';
45 }
17 </script> 46 </script>
OLDNEW
« no previous file with comments | « no previous file | Tools/GardeningServer/run-unittests.html » ('j') | Tools/GardeningServer/ui/ct-results-by-builder.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698