Kill ui.js

Kill ui.js

Move remaining ui.js functionality into existing classes and elements.

BUG=400393
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179993

[ojan, 2014-08-11 19:30:08]

lgtm

Yay! So much better.

https://codereview.chromium.org/459983002/diff/1/Tools/GardeningServer/model/...
File Tools/GardeningServer/model/ct-failure.html (right):

https://codereview.chromium.org/459983002/diff/1/Tools/GardeningServer/model/...
Tools/GardeningServer/model/ct-failure.html:18:
CTFailure.prototype.urlForFlakinessDashboard = function(tree) {
Nit: While we're moving it, how about we give it a better name?
flakinessDashboardUrl?

https://codereview.chromium.org/459983002/diff/1/Tools/GardeningServer/model/...
Tools/GardeningServer/model/ct-failure.html:21: // FIXME: Replace the flakiness
dashboard's sense of groups with sheriff-o-matic's
This fixme is now to get rid of the flakiness dashboard sense of groups.
crbug.com/400451

https://codereview.chromium.org/459983002/diff/1/Tools/GardeningServer/ui/ct-...
File Tools/GardeningServer/ui/ct-results-by-builder.html (right):

https://codereview.chromium.org/459983002/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-results-by-builder.html:37: displayName:
function(builder) {
We should get rid of this concept. Lets just show the whole builder name in the
tab.

[leviw_travelin_and_unemployed, 2014-08-11 21:33:40]

The CQ bit was checked by leviw@chromium.org

[commit-bot: I haz the power, 2014-08-11 21:35:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/leviw@chromium.org/459983002/1

[commit-bot: I haz the power, 2014-08-11 21:35:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-11 21:35:21]

Failed to apply patch for
Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
  |diff --git
a/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
b/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
  |index
93d7e0e78845366ce66cdecdda482dbe5800298d..613a69730d68a62ac29796a74bdcf50d566fa776
100644
  |--- a/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
  |+++ b/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
Index: Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
diff --git a/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
b/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
index
93d7e0e78845366ce66cdecdda482dbe5800298d..613a69730d68a62ac29796a74bdcf50d566fa776
100644
--- a/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
+++ b/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html
@@ -12,32 +12,18 @@ found in the LICENSE file.
 module("ct-embedded-flakiness-dashboard");
 
 asyncTest("url", 1, function() {
-  var oldUrlForEmbeddedFlakinessDashboard =
ui.urlForEmbeddedFlakinessDashboard;
-  var reset = function() {
-    ui.urlForEmbeddedFlakinessDashboard = oldUrlForEmbeddedFlakinessDashboard;
-  }
+  var failure = new CTFailure('foo_tests', 'foo/bar.html');
+  var tree = "blink";
+  var embeddedFlakinessDashboard =
document.createElement('ct-embedded-flakiness-dashboard');
 
-  try {
-    ui.urlForEmbeddedFlakinessDashboard = function(test, step, tree) { return
"about:blank#" + test + step + tree; }
-    var embeddedFlakinessDashboard =
document.createElement('ct-embedded-flakiness-dashboard');
-    var testName = "foo/bar.html";
-    var step = "foo_tests";
-    var tree = "blink";
-    embeddedFlakinessDashboard.test = {
-      testName: testName,
-      step: step,
-    };
-    embeddedFlakinessDashboard.tree = tree;
-
-    requestAnimationFrame(function() {
-      var iframe =
embeddedFlakinessDashboard.shadowRoot.querySelector('#iframe');
-      equal(iframe.src, ui.urlForEmbeddedFlakinessDashboard(testName, step,
tree));
-      reset();
-      start();
-    });
-  } catch (e) {
-    reset();
-  }
+  embeddedFlakinessDashboard.test = failure;
+  embeddedFlakinessDashboard.tree = tree;
+
+  requestAnimationFrame(function() {
+    var iframe =
embeddedFlakinessDashboard.shadowRoot.querySelector('#iframe');
+    equal(iframe.src, failure.urlForEmbeddedFlakinessDashboard(tree));
+    start();
+  });
 });
 
 asyncTest("heightChanged", 1, function() {

[leviw_travelin_and_unemployed, 2014-08-11 21:43:26]

The CQ bit was checked by leviw@chromium.org

[commit-bot: I haz the power, 2014-08-11 21:43:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/leviw@chromium.org/459983002/20001

[commit-bot: I haz the power, 2014-08-11 21:45:36]

Change committed as 179993