Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: components/bookmarks/common/android/bookmark_id.h

Issue 459973004: [Android] EnhancedBookmarksBridge for bookmark description read&write. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added back missing bookmark_type_list.h bookmark_type.h Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/common/android/bookmark_id.h
diff --git a/components/bookmarks/common/android/bookmark_id.h b/components/bookmarks/common/android/bookmark_id.h
new file mode 100644
index 0000000000000000000000000000000000000000..8bcfe9ae4faa18c6ef318899d802e9e378f83420
--- /dev/null
+++ b/components/bookmarks/common/android/bookmark_id.h
@@ -0,0 +1,19 @@
+ // Copyright 2014 The Chromium Authors. All rights reserved.
sky 2014/08/12 19:49:29 nit: you've got an extra space here.
Kibeom Kim (inactive) 2014/08/12 22:33:48 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
sky 2014/08/12 19:49:28 Do we typically not use header guards for these fi
Yaron 2014/08/12 20:15:49 It should be there
Kibeom Kim (inactive) 2014/08/12 22:33:48 Done.
+#include <jni.h>
+
+namespace bookmarks {
+namespace android {
sky 2014/08/12 19:49:28 Do we typically introduce namespaces for android s
Yaron 2014/08/12 20:15:48 I think it's fairly inconsistent :(
+
+// See BookmarkId#getId
+long JavaBookmarkIdGetId(JNIEnv* env, jobject obj);
+
+// See BookmarkId#getType
+int JavaBookmarkIdGetType(JNIEnv* env, jobject obj);
+
+bool RegisterBookmarkId(JNIEnv* env);
+
+} // namespace android
+} // namespace bookmarks

Powered by Google App Engine
This is Rietveld 408576698