components/bookmarks/common/android/bookmark_id.h - Issue 459973004: [Android] EnhancedBookmarksBridge for bookmark description read&write.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/bookmarks/common/android/bookmark_id.h

Issue 459973004: [Android] EnhancedBookmarksBridge for bookmark description read&write. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added back missing bookmark_type_list.h bookmark_type.h Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java ('K') | « components/bookmarks/common/android/OWNERS ('k') | components/bookmarks/common/android/bookmark_id.cc » ('j') | components/bookmarks/common/android/bookmark_type_list.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.
	sky 2014/08/12 19:49:29 nit: you've got an extra space here. nit: you've got an extra space here. Kibeom Kim (inactive) 2014/08/12 22:33:48 Done. Show quoted text On 2014/08/12 19:49:29, sky wrote: > nit: you've got an extra space here. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4
	sky 2014/08/12 19:49:28 Do we typically not use header guards for these fi Do we typically not use header guards for these files? Yaron 2014/08/12 20:15:49 It should be there Show quoted text On 2014/08/12 19:49:28, sky wrote: > Do we typically not use header guards for these files? It should be there Kibeom Kim (inactive) 2014/08/12 22:33:48 Done. Show quoted text On 2014/08/12 20:15:49, Yaron wrote: > On 2014/08/12 19:49:28, sky wrote: > > Do we typically not use header guards for these files? > > It should be there Done.
	5 #include <jni.h>

	6

	7 namespace bookmarks {

	8 namespace android {
	sky 2014/08/12 19:49:28 Do we typically introduce namespaces for android s Do we typically introduce namespaces for android specific things? Yaron 2014/08/12 20:15:48 I think it's fairly inconsistent :( Show quoted text On 2014/08/12 19:49:28, sky wrote: > Do we typically introduce namespaces for android specific things? I think it's fairly inconsistent :(
	9

	10 // See BookmarkId#getId

	11 long JavaBookmarkIdGetId(JNIEnv* env, jobject obj);

	12

	13 // See BookmarkId#getType

	14 int JavaBookmarkIdGetType(JNIEnv* env, jobject obj);

	15

	16 bool RegisterBookmarkId(JNIEnv* env);

	17

	18 } // namespace android

	19 } // namespace bookmarks

OLD	NEW