Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3406)

Unified Diff: chrome/browser/content_settings/permission_bubble_request_impl.cc

Issue 459953002: Migrate geolocation permissions to the new common permission class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_bubble_request_impl.cc
diff --git a/chrome/browser/content_settings/permission_bubble_request_impl.cc b/chrome/browser/content_settings/permission_bubble_request_impl.cc
index e37f0a7aea81535aa681710e1cf9271d9486c939..db10bf7b2c4f1e288c3b68afa57bfc7d0a64fffd 100644
--- a/chrome/browser/content_settings/permission_bubble_request_impl.cc
+++ b/chrome/browser/content_settings/permission_bubble_request_impl.cc
@@ -37,6 +37,9 @@ PermissionBubbleRequestImpl::~PermissionBubbleRequestImpl() {
int PermissionBubbleRequestImpl::GetIconID() const {
int icon_id;
switch (type_) {
+ case CONTENT_SETTINGS_TYPE_GEOLOCATION:
+ icon_id = IDR_INFOBAR_GEOLOCATION;
+ break;
#if defined(ENABLE_NOTIFICATIONS)
case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
icon_id = IDR_INFOBAR_DESKTOP_NOTIFICATIONS;
@@ -58,21 +61,24 @@ int PermissionBubbleRequestImpl::GetIconID() const {
base::string16 PermissionBubbleRequestImpl::GetMessageText() const {
int message_id;
switch (type_) {
+ case CONTENT_SETTINGS_TYPE_GEOLOCATION:
+ message_id = IDS_GEOLOCATION_INFOBAR_QUESTION;
+ break;
#if defined(ENABLE_NOTIFICATIONS)
- case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
- message_id = IDS_NOTIFICATION_PERMISSIONS;
- break;
+ case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
+ message_id = IDS_NOTIFICATION_PERMISSIONS;
+ break;
#endif
- case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
- message_id = IDS_MIDI_SYSEX_INFOBAR_QUESTION;
- break;
- case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
- message_id = IDS_PUSH_MESSAGES_PERMISSION_QUESTION;
- break;
- default:
- NOTREACHED();
- return base::string16();
- }
+ case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
+ message_id = IDS_MIDI_SYSEX_INFOBAR_QUESTION;
+ break;
+ case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
+ message_id = IDS_PUSH_MESSAGES_PERMISSION_QUESTION;
+ break;
+ default:
+ NOTREACHED();
+ return base::string16();
+ }
return l10n_util::GetStringFUTF16(
message_id,
net::FormatUrl(request_origin_, display_languages_,
@@ -84,6 +90,9 @@ base::string16 PermissionBubbleRequestImpl::GetMessageText() const {
base::string16 PermissionBubbleRequestImpl::GetMessageTextFragment() const {
int message_id;
switch (type_) {
+ case CONTENT_SETTINGS_TYPE_GEOLOCATION:
+ message_id = IDS_GEOLOCATION_INFOBAR_PERMISSION_FRAGMENT;
+ break;
#if defined(ENABLE_NOTIFICATIONS)
case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
message_id = IDS_NOTIFICATION_PERMISSIONS_FRAGMENT;

Powered by Google App Engine
This is Rietveld 408576698