Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 459953002: Migrate geolocation permissions to the new common permission class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 3e15ef8eefcb3059f7ff20a89220258ed905d854..d2cb7343cd009cc4e1109eb7bf1ccb8f5c7d22e2 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -1945,13 +1945,35 @@ void ChromeContentBrowserClient::RequestGeolocationPermission(
int bridge_id,
const GURL& requesting_frame,
bool user_gesture,
- base::Callback<void(bool)> result_callback,
- base::Closure* cancel_callback) {
+ const base::Callback<void(bool)>& result_callback) {
+ int render_process_id = web_contents->GetRenderProcessHost()->GetID();
+ int render_view_id = web_contents->GetRenderViewHost()->GetRoutingID();
+
+ const PermissionRequestID request_id(render_process_id,
+ render_view_id,
+ bridge_id,
+ requesting_frame);
GeolocationPermissionContextFactory::GetForProfile(
Profile::FromBrowserContext(web_contents->GetBrowserContext()))->
- RequestGeolocationPermission(web_contents, bridge_id,
- requesting_frame, user_gesture,
- result_callback, cancel_callback);
+ RequestPermission(web_contents, request_id,
+ requesting_frame.GetOrigin(), user_gesture,
+ result_callback);
+}
+
+void ChromeContentBrowserClient::CancelGeolocationPermissionRequest(
+ content::WebContents* web_contents,
+ int bridge_id,
+ const GURL& requesting_frame) {
+ int render_process_id = web_contents->GetRenderProcessHost()->GetID();
+ int render_view_id = web_contents->GetRenderViewHost()->GetRoutingID();
+
+ const PermissionRequestID request_id(render_process_id,
+ render_view_id,
+ bridge_id,
+ requesting_frame);
+ GeolocationPermissionContextFactory::GetForProfile(
+ Profile::FromBrowserContext(web_contents->GetBrowserContext()))->
+ CancelPermissionRequest(web_contents, request_id);
}
void ChromeContentBrowserClient::RequestMidiSysExPermission(

Powered by Google App Engine
This is Rietveld 408576698