Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 459943002: Revert of For consistency with benchmark, rename unittest.output_formatter -> progress_reporter. (Closed)

Created:
6 years, 4 months ago by ilja
Modified:
6 years, 4 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tic_gtest_did_run_test
Project:
chromium
Visibility:
Public.

Description

Revert of For consistency with benchmark, rename unittest.output_formatter -> progress_reporter. (https://codereview.chromium.org/439503006/) Reason for revert: Reverting due to ChromeOS break, see https://code.google.com/p/chromium/issues/detail?id=402451#c4 Original issue's description: > For consistency with benchmark, rename unittest.output_formatter -> progress_reporter. > > BUG=397746 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288541 TBR=nednguyen@google.com,dtu@chromium.org,nduca@chromium.org,kbr@chromium.org,dpranke@chromium.org,bolian@chromium.org,chrishenry@google.com NOTREECHECKS=true NOTRY=true BUG=397746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -426 lines) Patch
M content/test/gpu/run_unittests View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/chrome_proxy/run_tests View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/benchmark_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/run_tests View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/telemetry/run_tests View 1 chunk +4 lines, -4 lines 0 comments Download
A tools/telemetry/telemetry/unittest/gtest_output_formatter.py View 1 chunk +87 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/unittest/gtest_output_formatter_unittest.py View 1 chunk +125 lines, -0 lines 0 comments Download
D tools/telemetry/telemetry/unittest/gtest_progress_reporter.py View 1 chunk +0 lines, -87 lines 0 comments Download
D tools/telemetry/telemetry/unittest/gtest_progress_reporter_unittest.py View 1 chunk +0 lines, -128 lines 0 comments Download
A tools/telemetry/telemetry/unittest/output_formatter.py View 1 chunk +130 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/unittest/output_formatter_unittest.py View 1 chunk +54 lines, -0 lines 0 comments Download
D tools/telemetry/telemetry/unittest/progress_reporter.py View 1 chunk +0 lines, -130 lines 0 comments Download
D tools/telemetry/telemetry/unittest/progress_reporter_unittest.py View 1 chunk +0 lines, -54 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests.py View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ilja
Created Revert of For consistency with benchmark, rename unittest.output_formatter -> progress_reporter.
6 years, 4 months ago (2014-08-11 18:22:10 UTC) #1
ilja
The CQ bit was unchecked by ihf@chromium.org
6 years, 4 months ago (2014-08-11 18:50:58 UTC) #2
ilja
6 years, 4 months ago (2014-08-11 18:52:23 UTC) #3
Message was sent while issue was closed.
This was submitted by drover at
https://codereview.chromium.org/462793002

Powered by Google App Engine
This is Rietveld 408576698