Issue 462793002: Revert 288541 "For consistency with benchmark, rename unittest.o..."

Issue 462793002: Revert 288541 "For consistency with benchmark, rename unittest.o..." (Closed)

Created:
6 years, 4 months ago by ilja

Modified:
6 years, 4 months ago

Reviewers:
chrishenry

CC:
chromium-reviews, nednguyen

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 288541 "For consistency with benchmark, rename unittest.o..." > For consistency with benchmark, rename unittest.output_formatter -> progress_reporter. > > BUG=397746 > > Review URL: https://codereview.chromium.org/439503006 TBR=chrishenry@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288751

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -294 lines)			Patch
M	trunk/src/content/test/gpu/run_unittests	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	trunk/src/tools/chrome_proxy/run_tests	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	trunk/src/tools/perf/benchmarks/benchmark_unittest.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/tools/perf/run_tests	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	trunk/src/tools/telemetry/run_tests	View	1 chunk	+4 lines, -4 lines	0 comments	Download
A +	trunk/src/tools/telemetry/telemetry/unittest/gtest_output_formatter.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/tools/telemetry/telemetry/unittest/gtest_output_formatter_unittest.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	trunk/src/tools/telemetry/telemetry/unittest/gtest_progress_reporter.py	View	1 chunk	+0 lines, -87 lines	0 comments	Download
A +	trunk/src/tools/telemetry/telemetry/unittest/output_formatter.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/tools/telemetry/telemetry/unittest/output_formatter_unittest.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	trunk/src/tools/telemetry/telemetry/unittest/progress_reporter.py	View	1 chunk	+0 lines, -130 lines	0 comments	Download
D	trunk/src/tools/telemetry/telemetry/unittest/progress_reporter_unittest.py	View	1 chunk	+0 lines, -54 lines	0 comments	Download
M	trunk/src/tools/telemetry/telemetry/unittest/run_tests.py	View	4 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 6 (0 generated)

chrishenry

Is this a proper revert? Someone from my team now saw an error on importing ...

6 years, 4 months ago (2014-08-11 20:09:22 UTC) #3

jabdelmalek

On 2014/08/11 20:09:22, chrishenry wrote: > Is this a proper revert? Someone from my team ...

6 years, 4 months ago (2014-08-11 20:20:55 UTC) #4

jabdelmalek

On 2014/08/11 20:09:22, chrishenry wrote: > Is this a proper revert? Someone from my team ...

6 years, 4 months ago (2014-08-11 20:20:57 UTC) #5

ilja

6 years, 4 months ago (2014-08-11 20:21:47 UTC) #6

Message was sent while issue was closed.

Yes, it didn't get reverted.
http://src.chromium.org/viewvc/chrome/trunk/src/tools/telemetry/telemetry/uni...