Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1514)

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

Issue 459873003: Mojom generator: move Is.*Kind() functions into module.py and use them from all mojom_.*_generator.… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix java compilation Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl
diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl
index f55b137bd728dc709b2bad94f975d2f14d4501f4..11cb099543514b77b1a13458ae4cc86f6cf3c6ee 100644
--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl
+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl
@@ -22,13 +22,13 @@
if (!{{wrapper_type}}::Data_::Validate(
mojo::internal::DecodePointerRaw(&object->{{name}}.offset),
bounds_checker
-{%- if packed_field.field.kind|is_array_kind -%}
+{%- if packed_field.field.kind|is_any_array_kind -%}
, {{packed_field.field.kind|expected_array_size}}
{%- endif -%}
)) {
return false;
}
-{%- elif packed_field.field.kind|is_handle_kind %}
+{%- elif packed_field.field.kind|is_any_handle_kind %}
if (!bounds_checker->ClaimHandle(object->{{name}})) {
ReportValidationError(mojo::internal::VALIDATION_ERROR_ILLEGAL_HANDLE);
return false;
@@ -78,7 +78,7 @@
{%- for pf in struct.packed.packed_fields %}
{%- if pf.field.kind|is_object_kind %}
mojo::internal::Encode(&{{pf.field.name}}, handles);
-{%- elif pf.field.kind|is_handle_kind %}
+{%- elif pf.field.kind|is_any_handle_kind %}
mojo::internal::EncodeHandle(&{{pf.field.name}}, handles);
{%- endif %}
{%- endfor %}
@@ -88,7 +88,7 @@ mojo::internal::EncodeHandle(&{{pf.field.name}}, handles);
{%- for pf in struct.packed.packed_fields %}
{%- if pf.field.kind|is_object_kind %}
mojo::internal::Decode(&{{pf.field.name}}, handles);
-{%- elif pf.field.kind|is_handle_kind %}
+{%- elif pf.field.kind|is_any_handle_kind %}
mojo::internal::DecodeHandle(&{{pf.field.name}}, handles);
{%- endif %}
{%- endfor %}

Powered by Google App Engine
This is Rietveld 408576698