mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl - Issue 459873003: Mojom generator: move Is.*Kind() functions into module.py and use them from all mojom_.*_generator.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

Issue 459873003: Mojom generator: move Is.*Kind() functions into module.py and use them from all mojom_.*_generator.… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix java compilation Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

index 5d8b944fb1a5a359b29ab36245dfa39b1cec890c..f48cca72fb45734058cf6eda9554dc674c2d671a 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

@@ -18,7 +18,7 @@ void Serialize_({{struct.name}}Ptr input, mojo::internal::Buffer* buf,

Serialize_(mojo::internal::Forward(input->{{pf.field.name}}), buf, &result->{{pf.field.name}}.ptr);

{%- elif pf.field.kind|is_interface_kind %}

result->{{pf.field.name}} = input->{{pf.field.name}}.PassMessagePipe().release();

-{%- elif pf.field.kind|is_handle_kind %}

+{%- elif pf.field.kind|is_any_handle_kind %}

result->{{pf.field.name}} = input->{{pf.field.name}}.release();

{%- else %}

result->{{pf.field.name}} = input->{{pf.field.name}};

@@ -40,7 +40,7 @@ void Deserialize_(internal::{{struct.name}}_Data* input,

{%- elif pf.field.kind|is_interface_kind %}

if (input->{{pf.field.name}}.is_valid())

result->{{pf.field.name}}.Bind(mojo::MakeScopedHandle(mojo::internal::FetchAndReset(&input->{{pf.field.name}})));

-{%- elif pf.field.kind|is_handle_kind %}

+{%- elif pf.field.kind|is_any_handle_kind %}

result->{{pf.field.name}}.reset(mojo::internal::FetchAndReset(&input->{{pf.field.name}}));

{%- elif pf.field.kind|is_enum_kind %}

result->{{pf.field.name}} = static_cast<{{pf.field.kind|cpp_wrapper_type}}>(