Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 459873003: Mojom generator: move Is.*Kind() functions into module.py and use them from all mojom_.*_generator.… (Closed)

Created:
6 years, 4 months ago by yzshen1
Modified:
6 years, 4 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojom generator: move Is.*Kind() functions into module.py and use them from all mojom_.*_generator.py. This CL also makes the generators handle nullable types correctly. (But validation logic for non-nullable types will be in a separate CL.) BUG=324170 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288893

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : fix java compilation #

Messages

Total messages: 9 (0 generated)
yzshen1
Hi, Matt. Would you please take a look? Thanks!
6 years, 4 months ago (2014-08-11 20:23:57 UTC) #1
Matt Perry
lgtm https://codereview.chromium.org/459873003/diff/1/mojo/public/tools/bindings/pylib/mojom/generate/module.py File mojo/public/tools/bindings/pylib/mojom/generate/module.py (right): https://codereview.chromium.org/459873003/diff/1/mojo/public/tools/bindings/pylib/mojom/generate/module.py#newcode388 mojo/public/tools/bindings/pylib/mojom/generate/module.py:388: return (IsHandleKind(kind) or nit: simply checking that the ...
6 years, 4 months ago (2014-08-11 21:07:08 UTC) #2
yzshen1
Thanks Matt! https://codereview.chromium.org/459873003/diff/1/mojo/public/tools/bindings/pylib/mojom/generate/module.py File mojo/public/tools/bindings/pylib/mojom/generate/module.py (right): https://codereview.chromium.org/459873003/diff/1/mojo/public/tools/bindings/pylib/mojom/generate/module.py#newcode388 mojo/public/tools/bindings/pylib/mojom/generate/module.py:388: return (IsHandleKind(kind) or On 2014/08/11 21:07:07, Matt ...
6 years, 4 months ago (2014-08-11 21:17:59 UTC) #3
Matt Perry
https://codereview.chromium.org/459873003/diff/1/mojo/public/tools/bindings/pylib/mojom/generate/module.py File mojo/public/tools/bindings/pylib/mojom/generate/module.py (right): https://codereview.chromium.org/459873003/diff/1/mojo/public/tools/bindings/pylib/mojom/generate/module.py#newcode388 mojo/public/tools/bindings/pylib/mojom/generate/module.py:388: return (IsHandleKind(kind) or On 2014/08/11 21:17:59, yzshen1 wrote: > ...
6 years, 4 months ago (2014-08-11 21:25:56 UTC) #4
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-11 21:41:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/459873003/20001
6 years, 4 months ago (2014-08-11 21:46:12 UTC) #6
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-12 00:01:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/459873003/60001
6 years, 4 months ago (2014-08-12 00:06:42 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 03:16:39 UTC) #9
Message was sent while issue was closed. 
Change committed as 288893

Powered by Google App Engine
This is Rietveld 408576698